[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D13717: Implement Seek() and Seeked()
From: Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date: 2018-06-29 6:27:00
Message-ID: 1f94373b4bb3752db95f5e038f68e180 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
broulik added inline comments.
INLINE COMMENTS
> content-script.js:177
> + if (activePlayer) {
> + if (!(activePlayer.seekable.length > 0)) {
> + console.warn("Got seek command, but player is not seekable");
Please avoid negating a longer statement, this makes the code hard to understand at a \
glance:
if (activePlayer.seekable.length === 0)
> mokhtari wrote in mprisplugin.cpp:205
> MPrisPlugin doesn't define Seeked, so no. But it's fine with me if you think adding \
> it to the parent and using the signal auto-relaying would be better.
> Regarding macros vs. keywords, I just figured macros would be more compatible, but \
> it could be switched to using emit as well.
Doesn't it work if you define the signal in `mprisplugin.h` and emit there? The \
generated DBus code from the XML should auto-relay them. Agreed, it's somewhat magic.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D13717
To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, Danial0_0, \
johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, \
seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, \
abetts, sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13717">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13717#inline-72546">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">content-script.js:177</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#004012">activePlayer</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span \
style="color: #aa2211">!</span><span class="p">(</span><span style="color: \
#004012">activePlayer</span><span class="p">.</span><span style="color: \
#004012">seekable</span><span class="p">.</span><span style="color: \
#004012">length</span> <span style="color: #aa2211">></span> <span style="color: \
#601200">0</span><span class="p">))</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">console</span><span class="p">.</span><span \
style="color: #004012">warn</span><span class="p">(</span><span style="color: \
#766510">"Got seek command, but player is not seekable"</span><span \
class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Please avoid negating a longer statement, this makes the code hard to \
understand at a glance:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if \
(activePlayer.seekable.length === 0)</pre></div></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13717#inline-72519">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">mokhtari</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">mprisplugin.cpp:205</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">MPrisPlugin doesn't define Seeked, so no. But it's fine with me if \
you think adding it to the parent and using the signal auto-relaying would be \
better.</p>
<p style="padding: 0; margin: 8px;">Regarding macros vs. keywords, I just figured \
macros would be more compatible, but it could be switched to using emit as \
well.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: \
0; margin: 8px;">Doesn't it work if you define the signal in <tt \
style="background: #ebebeb; font-size: 13px;">mprisplugin.h</tt> and emit there? The \
generated DBus code from the XML should auto-relay them. Agreed, it's somewhat \
magic.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser \
Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13717">https://phabricator.kde.org/D13717</a></div></div><br \
/><div><strong>To: </strong>mokhtari, broulik<br /><strong>Cc: </strong>nicolasfella, \
plasma-devel, KDE Connect, timothyc, jdvr, yannux, Danial0_0, johnq, ragreen, Pitel, \
adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, bugzy, \
MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, \
apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic