[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13788: Use Pin/Unpin also for window tasks when there's only one activity
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-06-29 6:22:17
Message-ID: 9ae8cc2e5c30dac691d40be01780040d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

broulik added inline comments.

INLINE COMMENTS

> ContextMenu.qml:486
> 
> -        checkable: true
> -
> -        text: i18nc("Toggle action for showing a launcher button while the \
> application is not running", "&Pin") +        text: (isPinned ? i18nc("Action for \
> removing the launcher button shown while the application is not running", "Unpin") \
> +            : i18nc("Action for showing a launcher button while the application is \
> not running", "&Pin"))

Un&pin?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13788

To: hein, broulik
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13788">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13788#inline-72545">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ContextMenu.qml:486</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        \
<span class="bright"></span><span style="color: #aa4000"><span \
class="bright">checkable:</span></span><span class="bright"> </span><span \
style="color: #000a65"><span class="bright">true</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">        <span style="color: #aa4000">text:</span> <span style="color: \
#004012">i18nc</span><span class="p">(</span><span style="color: \
#766510">&quot;Toggle action for showing a launcher button while the application is \
not running&quot;</span><span class="p">,</span> <span style="color: \
#766510">&quot;&amp;Pin&quot;</span><span class="p">)</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        \
<span class="bright"></span><span style="color: #aa4000"><span \
class="bright">text:</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">isPinned</span></span><span class="bright"> \
</span><span style="color: #aa2211"><span class="bright">?</span></span><span \
class="bright"> </span><span style="color: #004012"><span \
class="bright">i18nc</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#766510"><span class="bright">&quot;Action for removing the launcher button shown \
while the application is not running&quot;</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #766510"><span \
class="bright">&quot;Unpin&quot;</span></span><span class="bright"></span><span \
class="p"><span class="bright">)</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">            \
</span><span style="color: #aa2211"><span class="bright">:</span></span><span \
class="bright"> </span><span style="color: #004012"><span \
class="bright">i18nc</span></span><span class="bright"></span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span style="color: \
#766510"><span class="bright">&quot;Action for showing a launcher button while the \
application is not running&quot;</span></span><span class="bright"></span><span \
class="p"><span class="bright">,</span></span><span class="bright"> </span><span \
style="color: #766510"><span class="bright">&quot;&amp;Pin&quot;</span></span><span \
class="bright"></span><span class="p"><span class="bright">))</span></span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Un&amp;pin?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13788">https://phabricator.kde.org/D13788</a></div></div><br \
/><div><strong>To: </strong>hein, broulik<br /><strong>Cc: </strong>ngraham, \
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]