[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D13717: Implement Seek() and Seeked()
From:       Adam Mokhtari <noreply () phabricator ! kde ! org>
Date:       2018-06-28 19:22:09
Message-ID: 51df000afad24d252de389294356ef77 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mokhtari added a comment.


  Regarding loops with the Media Player widget, I haven't noticed any (using KDE \
Neon, 5.13.1). What test would catch this?

INLINE COMMENTS

> broulik wrote in content-script.js:177
> The `seekable` property isn't an int but a `TimeRanges` object that tells you which \
> portions of the player are seekable so this will never be `false` 
> [1] https://www.w3schools.com/tags/av_prop_seekable.asp

Good catch. I uploaded a fix for this.

> broulik wrote in mprisplugin.cpp:205
> Can't you just do `emit Seeked(position)`?

MPrisPlugin doesn't define Seeked, so no. But it's fine with me if you think adding \
it to the parent and using the signal auto-relaying would be better.

Regarding macros vs. keywords, I just figured macros would be more compatible, but it \
could be switched to using emit as well.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D13717

To: mokhtari, broulik
Cc: nicolasfella, plasma-devel, #kde_connect, timothyc, jdvr, yannux, Danial0_0, \
johnq, ragreen, Pitel, adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, \
seebauer, bugzy, MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, \
abetts, sebas, apol, mart


[Attachment #3 (text/html)]

<table><tr><td style="">mokhtari added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13717">View Revision</a></tr></table><br \
/><div><div><p>Regarding loops with the Media Player widget, I haven&#039;t noticed \
any (using KDE Neon, 5.13.1). What test would catch this?</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13717#inline-72271">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">content-script.js:177</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">The <tt style="background: #ebebeb; font-size: 13px;">seekable</tt> property \
isn&#039;t an int but a <tt style="background: #ebebeb; font-size: \
13px;">TimeRanges</tt> object that tells you which portions of the player are \
seekable so this will never be <tt style="background: #ebebeb; font-size: \
13px;">false</tt></p>

<p style="padding: 0; margin: 8px;">[1] <a \
href="https://www.w3schools.com/tags/av_prop_seekable.asp" class="remarkup-link" \
target="_blank" rel="noreferrer">https://www.w3schools.com/tags/av_prop_seekable.asp</a></p></div></div>
 <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Good catch. I uploaded a fix for this.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13717#inline-72272">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">mprisplugin.cpp:205</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">Can&#039;t you just do <tt style="background: #ebebeb; font-size: 13px;">emit \
Seeked(position)</tt>?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">MPrisPlugin doesn&#039;t define Seeked, so \
no. But it&#039;s fine with me if you think adding it to the parent and using the \
signal auto-relaying would be better.</p>

<p style="padding: 0; margin: 8px;">Regarding macros vs. keywords, I just figured \
macros would be more compatible, but it could be switched to using emit as \
well.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser \
Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13717">https://phabricator.kde.org/D13717</a></div></div><br \
/><div><strong>To: </strong>mokhtari, broulik<br /><strong>Cc: </strong>nicolasfella, \
plasma-devel, KDE Connect, timothyc, jdvr, yannux, Danial0_0, johnq, ragreen, Pitel, \
adeen-s, SemperPeritus, ndavis, daniel.z.tg, jeanv, ZrenBot, seebauer, bugzy, \
MayeulC, menasshock, lesliezhai, ali-mohamed, jensreuterberg, ach, abetts, sebas, \
apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]