[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-04-30 12:55:14
Message-ID: 20180430125514.1.C9105E8B45065D87 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  flatpak_installation_list_installed_refs_for_update can return null,
  clearly we expect this as we catch it above and show an waring. But on
  finished in the lambda we call refs->len, which obviously crashes.
  
  onFetchUpdatesFinished doesnt' do anything with an empty list.
  
  BUG: 393614

TEST PLAN
  None, just read backtrace and code.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12610

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson created this revision.<br />davidedmundson \
added a reviewer: Plasma.<br />Restricted Application added a project: Plasma.<br \
/>Restricted Application added a subscriber: plasma-devel.<br />davidedmundson \
requested review of this revision. </td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12610">View Revision</a></tr></table><br \
/><div><strong>REVISION \
SUMMARY</strong><div><p>flatpak_installation_list_installed_refs_for_update can \
return null,<br /> clearly we expect this as we catch it above and show an waring. \
But on<br /> finished in the lambda we call refs-&gt;len, which obviously \
crashes.</p>

<p>onFetchUpdatesFinished doesnt&#039; do anything with an empty list.</p>

<p>BUG: 393614</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>None, just \
read backtrace and code.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R134 Discover Software \
Store</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12610">https://phabricator.kde.org/D12610</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp</div></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]