--a23ef803152f486fa614af41301dcac5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="ascii" Mime-Version: 1.0 davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY flatpak_installation_list_installed_refs_for_update can return null, clearly we expect this as we catch it above and show an waring. But on finished in the lambda we call refs->len, which obviously crashes. onFetchUpdatesFinished doesnt' do anything with an empty list. BUG: 393614 TEST PLAN None, just read backtrace and code. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D12610 AFFECTED FILES libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp To: davidedmundson, #plasma Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart --a23ef803152f486fa614af41301dcac5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="ascii" Mime-Version: 1.0
davidedmundson created this revision. davide= dmundson added a reviewer: Plasma. Restricted Application added a proj= ect: Plasma. Restricted Application added a subscriber: plasma-devel.<= br />davidedmundson requested review of this revision. | View Revision
flatpak_installation_list_in=
stalled_refs_for_update can return null,
clearly we expect this as we catch it above and show an waring. But on
finished in the lambda we call refs->len, which obviously crashes.
onFetchUpdatesFinished doesnt' do anything with an empty list.
BUG: 393614
= None, just read backtrace and code.