From kde-panel-devel  Mon Apr 30 12:55:14 2018
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: Mon, 30 Apr 2018 12:55:14 +0000
To: kde-panel-devel
Subject: D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update
Message-Id: <20180430125514.1.C9105E8B45065D87 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=152509293114251
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--a23ef803152f486fa614af41301dcac5"

--a23ef803152f486fa614af41301dcac5
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  flatpak_installation_list_installed_refs_for_update can return null,
  clearly we expect this as we catch it above and show an waring. But on
  finished in the lambda we call refs->len, which obviously crashes.
  
  onFetchUpdatesFinished doesnt' do anything with an empty list.
  
  BUG: 393614

TEST PLAN
  None, just read backtrace and code.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12610

AFFECTED FILES
  libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--a23ef803152f486fa614af41301dcac5
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">davidedmundson created this revision.<br />davide=
dmundson added a reviewer: Plasma.<br />Restricted Application added a proj=
ect: Plasma.<br />Restricted Application added a subscriber: plasma-devel.<=
br />davidedmundson requested review of this revision.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D12610">View Revision</a></tr></table><br /=
><div><strong>REVISION SUMMARY</strong><div><p>flatpak_installation_list_in=
stalled_refs_for_update can return null,<br />
clearly we expect this as we catch it above and show an waring. But on<br />
finished in the lambda we call refs-&gt;len, which obviously crashes.</p>

<p>onFetchUpdatesFinished doesnt&#039; do anything with an empty list.</p>

<p>BUG: 393614</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>=
None, just read backtrace and code.</p></div></div><br /><div><strong>REPOS=
ITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /=
><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><=
strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/=
D12610">https://phabricator.kde.org/D12610</a></div></div><br /><div><stron=
g>AFFECTED FILES</strong><div><div>libdiscover/backends/FlatpakBackend/Flat=
pakNotifier.cpp</div></div></div><br /><div><strong>To: </strong>davidedmun=
dson, Plasma<br /><strong>Cc: </strong>plasma-devel, ragreen, Pitel, ZrenBo=
t, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br />=
</div>
--a23ef803152f486fa614af41301dcac5--