[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D12498: Fully remove `Application Name` from Details panel
From:       Stefan_Brüns <noreply () phabricator ! kde ! org>
Date:       2018-04-27 19:40:50
Message-ID: 20180427194050.1.1BC4E1144A93610A () phabricator ! kde ! org
[Download RAW message or body]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> authdetails.ui:26
> <property name="text">
> -      <string>Action:</string>
> +      <string>Action ID:</string>
> </property>

Can you also change it for the placeholder label (row 2, col 1) - convention is to set both \
(actual label and placeholder) to the same value.

And while you are at it, use the same colspan value here as for the other col 1 entries (not \
you fault, missing since D11950 <https://phabricator.kde.org/D11950>).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">bruns requested changes to this revision.<br />bruns added inline \
comments.<br />This revision now requires changes to proceed. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12498">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: \
#F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12498#inline-64105">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">authdetails.ui:26</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; \
clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">     \
&lt;property name=&quot;text&quot;&gt; </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">      &lt;string&gt;Action:&lt;/string&gt; </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">      \
&lt;string&gt;Action<span class="bright"> ID</span>:&lt;/string&gt; </div><div style="padding: \
0 8px; margin: 0 4px; ">     &lt;/property&gt; </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you also \
change it for the placeholder label (row 2, col 1) - convention is to set both (actual label \
and placeholder) to the same value.</p>

<p style="padding: 0; margin: 8px;">And while you are at it, use the same colspan value here as \
for the other col 1 entries (not you fault, missing since <a \
href="https://phabricator.kde.org/D11950" style="background-color: #e7e7e7;  border-color: \
#e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: \
line-through;">D11950</a>).</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R121 Policykit (Polkit) KDE \
Agent</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12498">https://phabricator.kde.org/D12498</a></div></div><br \
/><div><strong>To: </strong>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: \
</strong>davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]