bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

View Inlineauthdetails.ui:26

     <property name="text">
      <string>Action:</string>
      <string>Action ID:</string>
     </property>

Can you also change it for the placeholder label (row 2, col 1) - convention is to set both (actual label and placeholder) to the same value.

And while you are at it, use the same colspan value here as for the other col 1 entries (not you fault, missing since D11950).

REPOSITORY

R121 Policykit (Polkit) KDE Agent

REVISION DETAIL

https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart