From kde-panel-devel  Fri Apr 27 19:40:50 2018
From: =?utf-8?q?Stefan_Br=C3=BCns?= <noreply () phabricator ! kde ! org>
Date: Fri, 27 Apr 2018 19:40:50 +0000
To: kde-panel-devel
Subject: D12498: Fully remove `Application Name` from Details panel
Message-Id: <20180427194050.1.1BC4E1144A93610A () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=152485806210615
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--f1bc61b10fa641438fd9fe00f4ac6813"

--f1bc61b10fa641438fd9fe00f4ac6813
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> authdetails.ui:26
>       <property name="text">
> -      <string>Action:</string>
> +      <string>Action ID:</string>
>       </property>

Can you also change it for the placeholder label (row 2, col 1) - convention is to set both (actual label and placeholder) to the same value.

And while you are at it, use the same colspan value here as for the other col 1 entries (not you fault, missing since D11950 <https://phabricator.kde.org/D11950>).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

--f1bc61b10fa641438fd9fe00f4ac6813
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">bruns requested changes to this revision.<br />br=
uns added inline comments.<br />This revision now requires changes to proce=
ed.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D12498">View Revision</a></tr></table><br /=
><div><strong>INLINE COMMENTS</strong><div><div style=3D"margin: 6px 0 12px=
 0;"><div style=3D"border: 1px solid #C7CCD9; border-radius: 3px;"><div sty=
le=3D"padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style:=
 solid; border-width: 0 0 1px 0; margin: 0;"><div style=3D"color: #74777d; =
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style=3D"float=
: right; text-decoration: none;" href=3D"https://phabricator.kde.org/D12498=
#inline-64105">View Inline</a><span style=3D"color: #4b4d51; font-weight: b=
old;">authdetails.ui:26</span></div>
<div style=3D"font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quo=
t;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px=
 0; margin: 0;"><div style=3D"padding: 0 8px; margin: 0 4px; ">     &lt;pro=
perty name=3D&quot;text&quot;&gt;
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(251, 17=
5, 175, .7);">      &lt;string&gt;Action:&lt;/string&gt;
</div><div style=3D"padding: 0 8px; margin: 0 4px; background: rgba(151, 23=
4, 151, .6);">      &lt;string&gt;Action<span class=3D"bright"> ID</span>:&=
lt;/string&gt;
</div><div style=3D"padding: 0 8px; margin: 0 4px; ">     &lt;/property&gt;
</div></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">Can you also change it for the placeholder label (row 2, col 1) -=
 convention is to set both (actual label and placeholder) to the same value=
.</p>

<p style=3D"padding: 0; margin: 8px;">And while you are at it, use the same=
 colspan value here as for the other col 1 entries (not you fault, missing =
since <a href=3D"https://phabricator.kde.org/D11950" style=3D"background-co=
lor: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D11950</a>).</p></di=
v></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R=
121 Policykit (Polkit) KDE Agent</div></div></div><br /><div><strong>REVISI=
ON DETAIL</strong><div><a href=3D"https://phabricator.kde.org/D12498">https=
://phabricator.kde.org/D12498</a></div></div><br /><div><strong>To: </stron=
g>sharvey, bruns, ngraham, davidedmundson<br /><strong>Cc: </strong>davided=
mundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,=
 ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>
--f1bc61b10fa641438fd9fe00f4ac6813--