[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11198: [libbreezecommon] add box shadow helper
From:       Hugo Pereira Da Costa <noreply () phabricator ! kde ! org>
Date:       2018-03-20 13:56:14
Message-ID: 20180320135614.1.597032628D9FCFCE () phabricator ! kde ! org
[Download RAW message or body]

hpereiradacosta added a comment.


  
  
  > I have updated the diff so the "Accepted" should have gone away because I could \
introduce a bug, etc. Most likely it's a bug, I don't know ... Or Phabricator has AI \
so it could recognize what changes you wanted and what changes the new diff \
introduced.  
  No no that's not how it works. 
  I deliberately accepted the revision, despite having still some comments about what \
should be implemented, because I trusted you that you would implement this and only \
this.   Basically when a revision is accepted, disregarding how many new diffs are \
uploaded to it, untill someone changes the status back to "request changes".   So ... \
Fill free to push

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11198">View Revision</a></tr></table><br \
/><div><div>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I \
have updated the diff so the &quot;Accepted&quot; should have gone away because I \
could introduce a bug, etc. Most likely it&#039;s a bug, I don&#039;t know ... Or \
Phabricator has AI so it could recognize what changes you wanted and what changes the \
new diff introduced.</p></blockquote>

<p>No no that&#039;s not how it works. <br />
I deliberately accepted the revision, despite having still some comments about what \
should be implemented, because I trusted you that you would implement this and only \
this. <br /> Basically when a revision is accepted, disregarding how many new diffs \
are uploaded to it, untill someone changes the status back to &quot;request \
changes&quot;. <br /> So ... Fill free to push</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11198">https://phabricator.kde.org/D11198</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]