[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11198: [libbreezecommon] add box shadow helper
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-03-21 0:19:54
Message-ID: 20180321001954.1.1D1D5084A5500B5D () phabricator ! kde ! org
[Download RAW message or body]

zzag added a comment.


  In D11198#229897 <https://phabricator.kde.org/D11198#229897>, @hpereiradacosta \
wrote:  
  > I deliberately accepted the revision, despite having still some comments about \
what should be implemented, because I trusted you that you would implement this and \
only this.   >  Basically when a revision is accepted, disregarding how many new \
diffs are uploaded to it, untill someone changes the status back to "request \
changes".  
  
  Thanks for explanation. The more I live, the more I learn. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11198">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11198#229897" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11198#229897</a>, <a \
href="https://phabricator.kde.org/p/hpereiradacosta/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@hpereiradacosta</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I deliberately accepted the revision, \
despite having still some comments about what should be implemented, because I \
trusted you that you would implement this and only this. <br />  Basically when a \
revision is accepted, disregarding how many new diffs are uploaded to it, untill \
someone changes the status back to &quot;request changes&quot;.</p></div> \
</blockquote>

<p>Thanks for explanation. The more I live, the more I learn. :)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11198">https://phabricator.kde.org/D11198</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]