[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D11198: [libbreezecommon] add box shadow helper
From:       Vlad Zagorodniy <noreply () phabricator ! kde ! org>
Date:       2018-03-20 13:03:44
Message-ID: 20180320130344.1.204A7358BBE6D8D5 () phabricator ! kde ! org
[Download RAW message or body]

zzag added a comment.


  In D11198#229871 <https://phabricator.kde.org/D11198#229871>, @hpereiradacosta \
wrote:  
  > In D11198#229870 <https://phabricator.kde.org/D11198#229870>, @zzag wrote:
  >
  > > @hpereiradacosta could you please accept this diff again? (I updated the diff)
  >
  >
  > Must I ? Here the revision is marked accepted and ready to be shipped. Or is it a \
problem with ARC ?  
  
  I have updated the diff so the "Accepted" should have gone away because I could \
introduce a bug, etc. Most likely it's a bug, I don't know ... Or Phabricator has AI \
so it could recognize what changes you wanted and what changes the new diff \
introduced.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, \
sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11198">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11198#229871" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11198#229871</a>, <a \
href="https://phabricator.kde.org/p/hpereiradacosta/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@hpereiradacosta</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D11198#229870" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D11198#229870</a>, <a \
href="https://phabricator.kde.org/p/zzag/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@zzag</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><a \
href="https://phabricator.kde.org/p/hpereiradacosta/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@hpereiradacosta</a> could you please accept this \
diff again? (I updated the diff)</p></div> </blockquote>

<p>Must I ? Here the revision is marked accepted and ready to be shipped. Or is it a \
problem with ARC ?</p></div> </blockquote>

<p>I have updated the diff so the &quot;Accepted&quot; should have gone away because \
I could introduce a bug, etc. Most likely it&#039;s a bug, I don&#039;t know ... Or \
Phabricator has AI so it could recognize what changes you wanted and what changes the \
new diff introduced.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11198">https://phabricator.kde.org/D11198</a></div></div><br \
/><div><strong>To: </strong>zzag, Breeze, VDG, hpereiradacosta<br /><strong>Cc: \
</strong>broulik, abetts, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, \
jensreuterberg, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]