[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6673: [Notifications] Manually remove remote images
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2018-01-28 1:11:40
Message-ID: 20180128011140.1.F1577172829A0D03 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  > This would fail with "invalid but webbrowser-parseable" html, but i guess we \
don't really care about it either, no?  
  That wouldn't solve anything as <img src="whatever" > without </img> would fail the \
XML remover but still end up getting loaded.  You could need to signal that it wasn't \
strippable, and the QtQuick item could load in plain text, but then the patch is \
getting more complex.  
  -----
  
  My comment looks surprisngly sensible, I'll follow that up tomorrow eve and see if \
it works. I'll run the test fvgot has in the earlier comment.  
  -----
  
  > Any reason we're not doing the filtering at the dataengine level?
  
  It's accessing the text document of the TextEdit; which avoids a double text \
document parse.  Though for the size of a notification at the frequency we get them, \
that's not a huge problem.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: aacid, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6673" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>This would fail with &quot;invalid but \
webbrowser-parseable&quot; html, but i guess we don&#039;t really care about it \
either, no?</p></blockquote>

<p>That wouldn&#039;t solve anything as &lt;img src=&quot;whatever&quot; &gt; without \
&lt;/img&gt; would fail the XML remover but still end up getting loaded.<br /> You \
could need to signal that it wasn&#039;t strippable, and the QtQuick item could load \
in plain text, but then the patch is getting more complex.</p>

<hr class="remarkup-hr" />

<p>My comment looks surprisngly sensible, I&#039;ll follow that up tomorrow eve and \
see if it works. I&#039;ll run the test fvgot has in the earlier comment.</p>

<hr class="remarkup-hr" />

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Any \
reason we&#039;re not doing the filtering at the dataengine level?</p></blockquote>

<p>It&#039;s accessing the text document of the TextEdit; which avoids a double text \
document parse.<br /> Though for the size of a notification at the frequency we get \
them, that&#039;s not a huge problem.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6673" \
rel="noreferrer">https://phabricator.kde.org/D6673</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, fvogt<br /><strong>Cc: </strong>aacid, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]