[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6673: [Notifications] Manually remove remote images
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-01-28 0:49:34
Message-ID: 20180128004934.1.FC7708ACD9A838F0 () phabricator ! kde ! org
[Download RAW message or body]

aacid added a comment.


  In https://phabricator.kde.org/D6673#197138, @broulik wrote:
  
  > > should just filter out everything other than b i u a and img with local src
  >
  > Sure, but how would you achieve this? Regular expressions aren't suitable for \
HTML. It's not like I went this overly complicated way for no reason.  
  
  By doing something similar to what \
https://cgit.kde.org/knotifications.git/tree/src/notifybypopup.cpp#n790 does?  
  This wold fail with "invalid but parseable" html, but i guess we don't really care \
about it either, no?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: aacid, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6673" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6673#197138" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6673#197138</a>, <a \
href="https://phabricator.kde.org/p/broulik/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@broulik</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>should just filter out everything other than b i u a \
and img with local src</p></blockquote>

<p>Sure, but how would you achieve this? Regular expressions aren&#039;t suitable for \
HTML. It&#039;s not like I went this overly complicated way for no reason.</p></div> \
</blockquote>

<p>By doing something similar to what <a \
href="https://cgit.kde.org/knotifications.git/tree/src/notifybypopup.cpp#n790" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://cgit.kde.org/knotifications.git/tree/src/notifybypopup.cpp#n790</a> \
does?</p>

<p>This wold fail with &quot;invalid but parseable&quot; html, but i guess we \
don&#039;t really care about it either, no?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6673" \
rel="noreferrer">https://phabricator.kde.org/D6673</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, fvogt<br /><strong>Cc: </strong>aacid, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]