[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6673: [Notifications] Manually remove remote images
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2018-01-28 1:14:54
Message-ID: 20180128011454.1.02B0130D4D3E81CF () phabricator ! kde ! org
[Download RAW message or body]

broulik added a comment.


  I think `QXmlStreamReader` may be the way to go, I wasn't aware on how strict the \
spec is wrt HTML support.  
  David, an `<img>` opening tag is still valid XHTML, you might receive a document \
ended prematurely error at the end since there won't be a closing tag but definitely \
worth a shot filtering out any tags other than `<b>` etc and stripping all attributes \
other than `src` with local URL, especially the `style` attribute.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6673

To: broulik, #plasma, fvogt
Cc: aacid, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6673" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I think <tt style="background: #ebebeb; \
font-size: 13px;">QXmlStreamReader</tt> may be the way to go, I wasn&#039;t aware on \
how strict the spec is wrt HTML support.</p>

<p>David, an <tt style="background: #ebebeb; font-size: 13px;">&lt;img&gt;</tt> \
opening tag is still valid XHTML, you might receive a document ended prematurely \
error at the end since there won&#039;t be a closing tag but definitely worth a shot \
filtering out any tags other than <tt style="background: #ebebeb; font-size: \
13px;">&lt;b&gt;</tt> etc and stripping all attributes other than <tt \
style="background: #ebebeb; font-size: 13px;">src</tt> with local URL, especially the \
<tt style="background: #ebebeb; font-size: 13px;">style</tt> \
attribute.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6673" \
rel="noreferrer">https://phabricator.kde.org/D6673</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma, fvogt<br /><strong>Cc: </strong>aacid, \
davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]