[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8924: Move the KDE Polkit-Agent into ksmserver
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-11-28 16:34:17
Message-ID: 20171128163416.10873.D86BBDDB865E5598 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  > On X11 ksmserver, on Wayland KWin?
  
  In principle great. It was the other possible choice.
  But this spawns a window, generally kwin is bad at having it's own windows, so it \
might not be trivial.  
  I certainly don't want to go down the route of kwin holding the name, then spawning \
the dialog separately with a socket communicating back passwords.  
  > The main task of ksmserver is being an X11 Session Manager.
  
  Based on the name, sure. 
  Based on the code...I wouldn't say "main".
  
  The autostart handling is just as important, and just as much code, we don't want \
that in a process that we consider irrelevant.  
  Thinking of the lonerg term picture, I see 3 options for handling that.
  
  1. We could split that out into it's own process and spawn that on both X and \
wayland.  2. Autostart could be made into a lib, and added to the ever-growing kwind
  3. Or we could port the X session code to use xcb_connect instead of \
QX11Info::connection().. would be another option, there's no need for it to match \
what the QPA is using.  
  Decide that, and I think we're implicitly deciding what we do with this patch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D8924

To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8924" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; \
background-color: #f8f9fc;"><p>On X11 ksmserver, on Wayland KWin?</p></blockquote>

<p>In principle great. It was the other possible choice.<br />
But this spawns a window, generally kwin is bad at having it&#039;s own windows, so \
it might not be trivial.</p>

<p>I certainly don&#039;t want to go down the route of kwin holding the name, then \
spawning the dialog separately with a socket communicating back passwords.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The \
main task of ksmserver is being an X11 Session Manager.</p></blockquote>

<p>Based on the name, sure. <br />
Based on the code...I wouldn&#039;t say &quot;main&quot;.</p>

<p>The autostart handling is just as important, and just as much code, we don&#039;t \
want that in a process that we consider irrelevant.</p>

<p>Thinking of the lonerg term picture, I see 3 options for handling that.</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">We could split that out into it&#039;s own process and \
spawn that on both X and wayland.</li> <li class="remarkup-list-item">Autostart could \
be made into a lib, and added to the ever-growing kwind</li> <li \
class="remarkup-list-item">Or we could port the X session code to use xcb_connect \
instead of QX11Info::connection().. would be another option, there&#039;s no need for \
it to match what the QPA is using.</li> </ol>

<p>Decide that, and I think we&#039;re implicitly deciding what we do with this \
patch.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8924" \
rel="noreferrer">https://phabricator.kde.org/D8924</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: \
</strong>graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]