[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D9037: use desktop file actions instead of global shortcuts
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-11-28 16:38:17
Message-ID: differential-rev-PHID-DREV-eixqd3rkp4nhz6o7fpqb-req () phabricator ! kde ! org
[Download RAW message or body]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Don't autostart KRunner, use actions in the desktop file to
  
  define global shortcuts and actions
  
  - install its desktop file in share/kglobalaccel to make shortcuts default
  - expand commandline options to permit more control via commandline

TEST PLAN
  works, as expected except
  
  - the first time the krunner window doesn't get keyboard focus, probably kwin blocking it
  - kconfigupdate stuff still missing

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/krunnerondemand

REVISION DETAIL
  https://phabricator.kde.org/D9037

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop
  krunner/main.cpp
  krunner/view.cpp

To: mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

[Attachment #3 (unknown)]

<table><tr><td style="">mart created this revision.<br />mart added a reviewer: \
Plasma.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9037" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><ul \
class="remarkup-list"> <li class="remarkup-list-item">Don&#039;t autostart KRunner, \
use actions in the desktop file to</li> </ul>

<p>define global shortcuts and actions</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">install its desktop file in share/kglobalaccel to make \
shortcuts default</li> <li class="remarkup-list-item">expand commandline options to \
permit more control via commandline</li> </ul></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>works, as expected except</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">the first time the krunner window doesn&#039;t get \
keyboard focus, probably kwin blocking it</li> <li \
class="remarkup-list-item">kconfigupdate stuff still missing</li> \
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>phab/krunnerondemand</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9037" \
rel="noreferrer">https://phabricator.kde.org/D9037</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>krunner/CMakeLists.txt<br /> \
krunner/krunner.desktop<br /> krunner/main.cpp<br />
krunner/view.cpp</div></div></div><br /><div><strong>To: </strong>mart, Plasma<br \
/><strong>Cc: </strong>plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]