[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: D8641: FormLayout
From: David Edmundson <noreply () phabricator ! kde ! org>
Date: 2017-11-28 15:20:09
Message-ID: 20171128152009.54838.A9CB0A0A9657D1B0 () phabricator ! kde ! org
[Download RAW message or body]
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Please don't push new API 5 days before a release tagging.
We'll still be able to make the Plasma 5.12 if we wait till Saturday.
INLINE COMMENTS
> FormLayout.qml:200-203
> + Layout.alignment: root.wideMode
> + ? (Qt.AlignRight | \
> (item.Kirigami.FormData.buddyFor.height > height * 2 ? Qt.AlignTop : \
> Qt.AlignVCenter)) + : (Qt.AlignLeft | \
> Qt.AlignBottom) + verticalAlignment: root.wideMode ? Text.AlignVCenter : \
> Text.AlignBottom
you should be able to just
Layout.fillHeight: true
then do all this in the verticalAlignment
REPOSITORY
R169 Kirigami
BRANCH
mart/formlayout
REVISION DETAIL
https://phabricator.kde.org/D8641
To: mart, #plasma, #kirigami, hein, davidedmundson
Cc: broulik, colomar, ngraham, davidedmundson, plasma-devel, ngiannip, ZrenBot, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
[Attachment #3 (unknown)]
<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson \
added a comment.<br />This revision is now accepted and ready to land. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D8641" \
rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Please don't \
push new API 5 days before a release tagging.</p>
<p>We'll still be able to make the Plasma 5.12 if we wait till \
Saturday.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8641#inline-40613" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">FormLayout.qml:200-203</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">Layout.alignment:</span> <span style="color: #004012">root</span><span \
class="p">.</span><span style="color: #004012">wideMode</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa2211">?</span> <span class="p">(</span><span style="color: \
#004012">Qt</span><span class="p">.</span><span style="color: \
#004012">AlignRight</span> <span style="color: #aa2211">|</span> <span \
class="p">(</span><span style="color: #004012">item</span><span \
class="p">.</span><span style="color: #004012">Kirigami</span><span \
class="p">.</span><span style="color: #004012">FormData</span><span \
class="p">.</span><span style="color: #004012">buddyFor</span><span \
class="p">.</span><span style="color: #004012">height</span> <span style="color: \
#aa2211">></span> <span style="color: #004012">height</span> <span style="color: \
#aa2211">*</span> <span style="color: #601200">2</span> <span style="color: \
#aa2211">?</span> <span style="color: #aa4000">Qt.AlignTop :</span> <span \
style="color: #004012">Qt</span><span class="p">.</span><span style="color: \
#004012">AlignVCenter</span><span class="p">))</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa2211">:</span> <span class="p">(</span><span style="color: \
#004012">Qt</span><span class="p">.</span><span style="color: \
#004012">AlignLeft</span> <span style="color: #aa2211">|</span> <span style="color: \
#004012">Qt</span><span class="p">.</span><span style="color: \
#004012">AlignBottom</span><span class="p">)</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">verticalAlignment:</span> <span style="color: #004012">root</span><span \
class="p">.</span><span style="color: #004012">wideMode</span> <span style="color: \
#aa2211">?</span> <span style="color: #aa4000">Text.AlignVCenter :</span> <span \
style="color: #004012">Text</span><span class="p">.</span><span style="color: \
#004012">AlignBottom</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">you \
should be able to just</p>
<p style="padding: 0; margin: 8px;">Layout.fillHeight: true</p>
<p style="padding: 0; margin: 8px;">then do all this in the \
verticalAlignment</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>mart/formlayout</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8641" \
rel="noreferrer">https://phabricator.kde.org/D8641</a></div></div><br \
/><div><strong>To: </strong>mart, Plasma, Kirigami, hein, davidedmundson<br \
/><strong>Cc: </strong>broulik, colomar, ngraham, davidedmundson, plasma-devel, \
ngiannip, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, \
apol, mart, hein<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic