[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D8582: [platforms/drm] Add support for rotation property on the Plane
From:       Martin_Flöser <noreply () phabricator ! kde ! org>
Date:       2017-10-31 19:35:25
Message-ID: 20171031193524.104659.079290B1215EFB11 () phabricator ! kde ! org
[Download RAW message or body]

graesslin added a comment.


  In https://phabricator.kde.org/D8582#162577, @davidedmundson wrote:
  
  > Do you think we'll need a compositor fallback?
  >
  > *If* we do have a compositor fallback, then I don't see the point of a DRM \
specific codepath, it's not going to have any slower having a transform in painting, \
and will just result in one code path not getting tested.  >
  > To mostly answer my own question:
  >
  > In hwcomposer, it seems we have a transform attribute on the layer.
  >
  > For nested wayland we can set a transform on our wl_surface.
  >
  > For FBDev or nested in X, I don't think we can. But probably don't care?
  
  
  Yep. And that's why I don't want to add a compositor fallback. Doing the fallback \
looked quite complex when I looked at it due to multi screen.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D8582

To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart


[Attachment #3 (unknown)]

<table><tr><td style="">graesslin added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8582" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D8582#162577" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D8582#162577</a>, <a \
href="https://phabricator.kde.org/p/davidedmundson/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Do you think we&#039;ll need a compositor \
fallback?</p>

<p>*If* we do have a compositor fallback, then I don&#039;t see the point of a DRM \
specific codepath, it&#039;s not going to have any slower having a transform in \
painting, and will just result in one code path not getting tested.</p>

<p>To mostly answer my own question:</p>

<p>In hwcomposer, it seems we have a transform attribute on the layer.</p>

<p>For nested wayland we can set a transform on our wl_surface.</p>

<p>For FBDev or nested in X, I don&#039;t think we can. But probably don&#039;t \
care?</p></div> </blockquote>

<p>Yep. And that&#039;s why I don&#039;t want to add a compositor fallback. Doing the \
fallback looked quite complex when I looked at it due to multi \
screen.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 \
KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8582" \
rel="noreferrer">https://phabricator.kde.org/D8582</a></div></div><br \
/><div><strong>To: </strong>graesslin, KWin, Plasma, subdiff<br /><strong>Cc: \
</strong>davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]