[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6443: [CurrentContainmentActionsModel] Add configurationChanged signal
From:       Marco Martin <noreply () phabricator ! kde ! org>
Date:       2017-06-30 14:09:21
Message-ID: 20170630140920.27265.E3B76B86747AF012 () phabricator ! kde ! org
[Download RAW message or body]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in currentcontainmentactionsmodel.cpp:217
> Hmm I pass in "this" but it's nowhere guarded :/

yeah, it may crash.. whatever is in the 3rd param of the connect is the one you can \
not worry about, the other one may get dangling.. the only way i guess is to look at \
the code and be really sure that the CurrentContainmentActionsModel always outlives \
either configDlg or pluginInstance, which it *should*, but i'm not 100% sure

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6443

To: broulik, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">mart added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6443" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D6443#inline-26603" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">broulik</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">currentcontainmentactionsmodel.cpp:217</span></div> <div style="margin: 8px 0; \
padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Hmm I pass in \
&quot;this&quot; but it&#039;s nowhere guarded :/</p></div></div> <div style="margin: \
8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">yeah, it may crash.. \
whatever is in the 3rd param of the connect is the one you can not worry about, the \
other one may get dangling..<br /> the only way i guess is to look at the code and be \
really sure that the CurrentContainmentActionsModel always outlives either configDlg \
or pluginInstance, which it *should*, but i&#039;m not 100% \
sure</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6443" \
rel="noreferrer">https://phabricator.kde.org/D6443</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>mart, \
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]