[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D6443: [CurrentContainmentActionsModel] Add configurationChanged signal
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-07-03 8:31:36
Message-ID: 20170703083130.99266.5F31140D4D4B6C81 () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added a comment.


  Can you please upload patches with arc otherwise we don't get to expand the \
context.  
  Plugins have the lifespan of containment. (but could change as user toggles things)
  ConfigDlg lasts till it's quit
  This model is owned by the ContainmentConfigView.
  
  So you're right to question that, it's a good catch.
  
  But it's easily fixable, pass this a parent to configdlg - or just use two connect \
statements.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6443

To: broulik, #plasma
Cc: davidedmundson, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6443" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Can you please upload patches with arc \
otherwise we don&#039;t get to expand the context.</p>

<p>Plugins have the lifespan of containment. (but could change as user toggles \
things)<br /> ConfigDlg lasts till it&#039;s quit<br />
This model is owned by the ContainmentConfigView.</p>

<p>So you&#039;re right to question that, it&#039;s a good catch.</p>

<p>But it&#039;s easily fixable, pass this a parent to configdlg - or just use two \
connect statements.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R120 Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6443" \
rel="noreferrer">https://phabricator.kde.org/D6443</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>davidedmundson, \
mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, \
abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]