--db121ce321284c5bb63055e677074acf
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0

mart added inline comments.

INLINE COMMENTS

> broulik wrote in currentcontainmentactionsmodel.cpp:217
> Hmm I pass in "this" but it's nowhere guarded :/

yeah, it may crash.. whatever is in the 3rd param of the connect is the one you can not worry about, the other one may get dangling..
the only way i guess is to look at the code and be really sure that the CurrentContainmentActionsModel always outlives either configDlg or pluginInstance, which it *should*, but i'm not 100% sure

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6443

To: broulik, #plasma
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

--db121ce321284c5bb63055e677074acf
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0

<table><tr><td style=3D"">mart added inline comments.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D6443" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style=3D"=
margin: 6px 0 12px 0;"><div style=3D"border: 1px solid #C7CCD9; border-radi=
us: 3px;"><div style=3D"padding: 0; background: #F7F7F7; border-color: #e3e=
4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style=
=3D"color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden=
;"><a style=3D"float: right; text-decoration: none;" href=3D"https://phabri=
cator.kde.org/D6443#inline-26603" rel=3D"noreferrer">View Inline</a><span s=
tyle=3D"color: #4b4d51; font-weight: bold;">broulik</span> wrote in <span s=
tyle=3D"color: #4b4d51; font-weight: bold;">currentcontainmentactionsmodel.=
cpp:217</span></div>
<div style=3D"margin: 8px 0; padding: 0 12px; color: #74777D;"><p style=3D"=
padding: 0; margin: 8px;">Hmm I pass in &quot;this&quot; but it&#039;s nowh=
ere guarded :/</p></div></div>
<div style=3D"margin: 8px 0; padding: 0 12px;"><p style=3D"padding: 0; marg=
in: 8px;">yeah, it may crash.. whatever is in the 3rd param of the connect =
is the one you can not worry about, the other one may get dangling..<br />
the only way i guess is to look at the code and be really sure that the Cur=
rentContainmentActionsModel always outlives either configDlg or pluginInsta=
nce, which it *should*, but i&#039;m not 100% sure</p></div></div></div></d=
iv></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Worksp=
ace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a hre=
f=3D"https://phabricator.kde.org/D6443" rel=3D"noreferrer">https://phabrica=
tor.kde.org/D6443</a></div></div><br /><div><strong>To: </strong>broulik, P=
lasma<br /><strong>Cc: </strong>mart, plasma-devel, ZrenBot, progwolff, les=
liezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>
--db121ce321284c5bb63055e677074acf--