[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5659: Get output size with output-geometry() rather than mode size directly
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-04-29 17:24:02
Message-ID: differential-rev-PHID-DREV-ueff3uls25drgapewo2m-req () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We can use output->geometry to get the current mode size with transform
  applied simplifying a bunch of code, whilst being currently exactly the
  same code.
  
  This also applies the is->horizontal ? width : height to the
  displaySwitch button. Fixing a bug if you had a rotated laptop
  monitor then pressed the display switch button then it would be using the 
  wrong geometry.
  
  ----
  
  Real reason for this patch is that if I make geometry() the definitive
  call for getting output size with transformations I can then do all the
  scaling support in a simple tidy one-line edit.

REPOSITORY
  R104 KScreen

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5659

AFFECTED FILES
  kded/generator.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[Attachment #3 (text/html)]

<table><tr><td style="">davidedmundson created this revision.<br />Restricted \
Application added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5659" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We can \
use output-&gt;geometry to get the current mode size with transform<br /> applied \
simplifying a bunch of code, whilst being currently exactly the<br /> same code.</p>

<p>This also applies the is-&gt;horizontal ? width : height to the<br />
displaySwitch button. Fixing a bug if you had a rotated laptop<br />
monitor then pressed the display switch button then it would be using the <br />
wrong geometry.</p>

<hr class="remarkup-hr" />

<p>Real reason for this patch is that if I make geometry() the definitive<br />
call for getting output size with transformations I can then do all the<br />
scaling support in a simple tidy one-line edit.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R104 KScreen</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5659" \
rel="noreferrer">https://phabricator.kde.org/D5659</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>kded/generator.cpp</div></div></div><br /><div><strong>To: \
</strong>davidedmundson, Plasma<br /><strong>Cc: </strong>plasma-devel, spstarr, \
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br \
/></div>



[prev in list] [next in list] [prev in thread] [next in thread]