[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    D5657: StreamRestore: Don't write unnecessary changes
From:       David Rosca <noreply () phabricator ! kde ! org>
Date:       2017-04-29 16:46:21
Message-ID: differential-rev-PHID-DREV-pohgwm7gwojmthmp3nln-req () phabricator ! kde ! org
[Download RAW message or body]

drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Applet updates mute state with every volume change - it does
  writeChanges(volume) immediately following with writeChanges(mute)
  and it seems to make PulseAudio to ignore the volume change.
  This makes sure that writeChanges() is only called when something really
  changed.
  
  BUG: 367688
  FIXED-IN: 5.10.0

TEST PLAN
  I can't reproduce the issue myself, but it was confirmed in bugreport
  that this patch fixes the issue.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5657

AFFECTED FILES
  src/streamrestore.cpp

To: drosca, #plasma
Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

[Attachment #3 (text/html)]

<table><tr><td style="">drosca created this revision.<br />Restricted Application \
added a project: Plasma.<br />Restricted Application added a subscriber: \
plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D5657" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Applet \
updates mute state with every volume change - it does<br /> writeChanges(volume) \
immediately following with writeChanges(mute)<br /> and it seems to make PulseAudio \
to ignore the volume change.<br /> This makes sure that writeChanges() is only called \
when something really<br /> changed.</p>

<p>BUG: 367688<br />
FIXED-IN: 5.10.0</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I \
can&#039;t reproduce the issue myself, but it was confirmed in bugreport<br /> that \
this patch fixes the issue.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R115 Plasma Audio Volume \
Applet</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>master</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D5657" \
rel="noreferrer">https://phabricator.kde.org/D5657</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/streamrestore.cpp</div></div></div><br /><div><strong>To: \
</strong>drosca, Plasma<br /><strong>Cc: </strong>plasma-devel, spstarr, progwolff, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]