[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Commented On] D3885: Minor fix for plasma folder view filename editor
From:       "subdiff (Roman Gilg)" <noreply () phabricator ! kde ! org>
Date:       2016-12-31 11:51:45
Message-ID: 20161231115145.10639.68416.FB50D2D4 () phabricator ! kde ! org
[Download RAW message or body]

subdiff added a comment.


  Good find but why does it need to compare `_height` with `contentHeight` in the \
beginning at all? Normally what should imo happen is simply:  
  - Compare `realHeight` with max possible height `maxHeight`
  - If larger, set `_height = realHeight`, else `_height = maxHeight`
  
  So just: `_height = Math.min(realHeight, maxHeight)`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3885

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, #plasma
Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">subdiff added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3885" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>Good find but why does it need to compare \
<tt style="background: #ebebeb; font-size: 13px;">_height</tt> with <tt \
style="background: #ebebeb; font-size: 13px;">contentHeight</tt> in the beginning at \
all? Normally what should imo happen is simply:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">Compare <tt style="background: #ebebeb; font-size: \
13px;">realHeight</tt> with max possible height <tt style="background: #ebebeb; \
font-size: 13px;">maxHeight</tt></li> <li class="remarkup-list-item">If larger, set \
<tt style="background: #ebebeb; font-size: 13px;">_height = realHeight</tt>, else <tt \
style="background: #ebebeb; font-size: 13px;">_height = maxHeight</tt></li> </ul>

<p>So just: <tt style="background: #ebebeb; font-size: 13px;">_height = \
Math.min(realHeight, maxHeight)</tt></p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3885" \
rel="noreferrer">https://phabricator.kde.org/D3885</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>chinmoyr, Plasma<br /><strong>Cc: </strong>subdiff, \
plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]