--c33cdab2f37643f7ad36655ede2027e1
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

subdiff added a comment.


  Good find but why does it need to compare `_height` with `contentHeight` in the beginning at all? Normally what should imo happen is simply:
  
  - Compare `realHeight` with max possible height `maxHeight`
  - If larger, set `_height = realHeight`, else `_height = maxHeight`
  
  So just: `_height = Math.min(realHeight, maxHeight)`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3885

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, #plasma
Cc: subdiff, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--c33cdab2f37643f7ad36655ede2027e1
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">subdiff added a comment.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D3885" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><div><p>Good find but why does it need to compare <=
tt style=3D"background: #ebebeb; font-size: 13px;">_height</tt> with <tt st=
yle=3D"background: #ebebeb; font-size: 13px;">contentHeight</tt> in the beg=
inning at all? Normally what should imo happen is simply:</p>

<ul class=3D"remarkup-list">
<li class=3D"remarkup-list-item">Compare <tt style=3D"background: #ebebeb; =
font-size: 13px;">realHeight</tt> with max possible height <tt style=3D"bac=
kground: #ebebeb; font-size: 13px;">maxHeight</tt></li>
<li class=3D"remarkup-list-item">If larger, set <tt style=3D"background: #e=
bebeb; font-size: 13px;">_height =3D realHeight</tt>, else <tt style=3D"bac=
kground: #ebebeb; font-size: 13px;">_height =3D maxHeight</tt></li>
</ul>

<p>So just: <tt style=3D"background: #ebebeb; font-size: 13px;">_height =3D=
 Math.min(realHeight, maxHeight)</tt></p></div></div><br /><div><strong>REP=
OSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><=
strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.org/=
D3885" rel=3D"noreferrer">https://phabricator.kde.org/D3885</a></div></div>=
<br /><div><strong>EMAIL PREFERENCES</strong><div><a href=3D"https://phabri=
cator.kde.org/settings/panel/emailpreferences/" rel=3D"noreferrer">https://=
phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><=
div><strong>To: </strong>chinmoyr, Plasma<br /><strong>Cc: </strong>subdiff=
, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /=
></div>
--c33cdab2f37643f7ad36655ede2027e1--