[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-12-31 10:57:00
Message-ID: 20161231105700.26347.85357 () mimi ! kde ! org
[Download RAW message or body]
--===============0077780267852711215==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129732/
-----------------------------------------------------------
(Updated Dec. 31, 2016, 10:56 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, David Faure and Friedrich W. H. Kossebau.
Changes
-------
Submitted with commit 87b27476cc8a3865994da066ce06a3e836462719 by Albert Astals Cid \
to branch Plasma/5.8.
Repository: plasma-integration
Description
-------
7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 makes the save dialog appear as Open dialog.
Simplify the code in that commit so it does not regress anymore.
Comes with a unit test (argably a bit meh since it could loop forever if the dialog \
does not show, but i guess it is good if that happens too :D)
Diffs
-----
autotests/kfiledialog_unittest.cpp 47a5543
src/platformtheme/kdeplatformfiledialoghelper.cpp 990b983
Diff: https://git.reviewboard.kde.org/r/129732/diff/
Testing
-------
New test fails without the patch, works with it. Kate Save As dialog no longer shows \
as Open dialog.
Thanks,
Albert Astals Cid
--===============0077780267852711215==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129732/">https://git.reviewboard.kde.org/r/129732/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Faure and Friedrich W. H. Kossebau.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2016, 10:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 87b27476cc8a3865994da066ce06a3e836462719 by Albert \
Astals Cid to branch Plasma/5.8.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-integration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 makes the \
save dialog appear as Open dialog.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Simplify the code in \
that commit so it does not regress anymore.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Comes with a unit test \
(argably a bit meh since it could loop forever if the dialog does not show, but i \
guess it is good if that happens too :D)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New test fails without the patch, works with it. Kate \
Save As dialog no longer shows as Open dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kfiledialog_unittest.cpp <span style="color: \
grey">(47a5543)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(990b983)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129732/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0077780267852711215==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic