[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Request, 10 lines] D3885: Minor fix for plasma folder view filename editor
From: "chinmoyr (Chinmoy Ranjan Pradhan)" <noreply () phabricator ! kde ! org>
Date: 2016-12-31 10:26:49
Message-ID: differential-rev-PHID-DREV-bxeumxklctbbsg5ftx3r-req () phabricator ! kde ! org
[Download RAW message or body]
chinmoyr created this revision.
chinmoyr added a reviewer: Plasma.
chinmoyr set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
In filename editor(when wrap mode is on) the content height and height of \
Plasma::TextArea are out of sync. When text is added the height of TextArea \
increases as expected but when text is deleted the height doesn't decrease. \
F1648735: rename_editor_1.png <https://phabricator.kde.org/F1648735> F1648734: \
rename_editor_2.png <https://phabricator.kde.org/F1648734>
This patch attempts to fix the issue.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3885
AFFECTED FILES
containments/desktop/package/contents/ui/FolderView.qml
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: chinmoyr, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Attachment #3 (text/html)]
<table><tr><td style="">chinmoyr created this revision.<br />chinmoyr added a \
reviewer: Plasma.<br />chinmoyr set the repository for this revision to R119 Plasma \
Desktop.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D3885" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>In \
filename editor(when wrap mode is on) the content height and height of \
Plasma::TextArea are out of sync. <br /> When text is added the height of TextArea \
increases as expected but when text is deleted the height doesn't decrease. <br \
/> <a href="https://phabricator.kde.org/F1648735" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F1648735: \
rename_editor_1.png</a> <a href="https://phabricator.kde.org/F1648734" \
style="background-color: #e7e7e7; border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F1648734: \
rename_editor_2.png</a></p>
<p>This patch attempts to fix the issue.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D3885" \
rel="noreferrer">https://phabricator.kde.org/D3885</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>containments/desktop/package/contents/ui/FolderView.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>chinmoyr, Plasma<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic