From kde-panel-devel  Sat Dec 31 10:26:49 2016
From: "chinmoyr (Chinmoy Ranjan Pradhan)" <noreply () phabricator ! kde ! org>
Date: Sat, 31 Dec 2016 10:26:49 +0000
To: kde-panel-devel
Subject: [Differential] [Request, 10 lines] D3885: Minor fix for plasma folder view filename editor
Message-Id: <differential-rev-PHID-DREV-bxeumxklctbbsg5ftx3r-req () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=148318002703840
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--2c5c4332e362447496171515e445a2c5"

--2c5c4332e362447496171515e445a2c5
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

chinmoyr created this revision.
chinmoyr added a reviewer: Plasma.
chinmoyr set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In filename editor(when wrap mode is on) the content height and height of Plasma::TextArea are out of sync. 
  When text is added the height of TextArea increases as expected but when text is deleted the height doesn't decrease. 
  F1648735: rename_editor_1.png <https://phabricator.kde.org/F1648735> F1648734: rename_editor_2.png <https://phabricator.kde.org/F1648734>
  
  This patch attempts to fix the issue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3885

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

--2c5c4332e362447496171515e445a2c5
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td style=3D"">chinmoyr created this revision.<br />chinmoyr add=
ed a reviewer: Plasma.<br />chinmoyr set the repository for this revision t=
o R119 Plasma Desktop.<br />Restricted Application added a project: Plasma.=
<br />Restricted Application added a subscriber: plasma-devel.
</td><a style=3D"text-decoration: none; padding: 4px 8px; margin: 0 8px 8px=
; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; back=
ground-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1=
f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href=
=3D"https://phabricator.kde.org/D3885" rel=3D"noreferrer">View Revision</a>=
</tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>In filenam=
e editor(when wrap mode is on) the content height and height of Plasma::Tex=
tArea are out of sync. <br />
When text is added the height of TextArea increases as expected but when te=
xt is deleted the height doesn&#039;t decrease. <br />
<a href=3D"https://phabricator.kde.org/F1648735" style=3D"background-color:=
 #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">F1648735:=
 rename_editor_1.png</a> <a href=3D"https://phabricator.kde.org/F1648734" s=
tyle=3D"background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel=3D"noreferrer">F1648734:=
 rename_editor_2.png</a></p>

<p>This patch attempts to fix the issue.</p></div></div><br /><div><strong>=
REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><di=
v><strong>REVISION DETAIL</strong><div><a href=3D"https://phabricator.kde.o=
rg/D3885" rel=3D"noreferrer">https://phabricator.kde.org/D3885</a></div></d=
iv><br /><div><strong>AFFECTED FILES</strong><div><div>containments/desktop=
/package/contents/ui/FolderView.qml</div></div></div><br /><div><strong>EMA=
IL PREFERENCES</strong><div><a href=3D"https://phabricator.kde.org/settings=
/panel/emailpreferences/" rel=3D"noreferrer">https://phabricator.kde.org/se=
ttings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </stro=
ng>chinmoyr, Plasma<br /><strong>Cc: </strong>plasma-devel, lesliezhai, ali=
-mohamed, jensreuterberg, abetts, sebas<br /></div>
--2c5c4332e362447496171515e445a2c5--