[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129732: Fix regression in which the save dialog appears as an Open dialog
From: Albert Astals Cid <aacid () kde ! org>
Date: 2016-12-31 9:42:27
Message-ID: 20161231094227.26347.72272 () mimi ! kde ! org
[Download RAW message or body]
--===============7224698047034425481==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Dec. 31, 2016, 8:40 a.m., David Faure wrote:
> > autotests/kfiledialog_unittest.cpp, line 106
> > <https://git.reviewboard.kde.org/r/129732/diff/1/?file=488327#file488327line106>
> >
> > A better approach would be
> > QTRY_VERIFY(findFileWidget());
> >
> > This will repeatedly call findFileWidget() until it works or until 5 seconds have \
> > passed. Then you don't need timers nor separate methods nor a new member \
> > variable. The rest of the test can just follow that line.
Had a problem with this since i needed to be able to close the window and i haven't \
been able to get a tryVerify that waits for qApp->activeWindow, it gets stuck and the \
dialog never shows, workarounded by waiting for the focus signal in qApp instead.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129732/#review101680
-----------------------------------------------------------
On Dec. 31, 2016, 9:42 a.m., Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129732/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2016, 9:42 a.m.)
>
>
> Review request for Plasma, David Faure and Friedrich W. H. Kossebau.
>
>
> Repository: plasma-integration
>
>
> Description
> -------
>
> 7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 makes the save dialog appear as Open \
> dialog.
> Simplify the code in that commit so it does not regress anymore.
>
> Comes with a unit test (argably a bit meh since it could loop forever if the dialog \
> does not show, but i guess it is good if that happens too :D)
>
> Diffs
> -----
>
> autotests/kfiledialog_unittest.cpp 47a5543
> src/platformtheme/kdeplatformfiledialoghelper.cpp 990b983
>
> Diff: https://git.reviewboard.kde.org/r/129732/diff/
>
>
> Testing
> -------
>
> New test fails without the patch, works with it. Kate Save As dialog no longer \
> shows as Open dialog.
>
> Thanks,
>
> Albert Astals Cid
>
>
--===============7224698047034425481==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129732/">https://git.reviewboard.kde.org/r/129732/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 31st, 2016, 8:40 a.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/129732/diff/1/?file=488327#file488327line106" \
style="color: black; font-weight: bold; text-decoration: \
underline;">autotests/kfiledialog_unittest.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">106</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QTimer</span><span class="o">::</span><span \
class="n">singleShot</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span> <span class="k">this</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span \
class="n">checkSaveFileUrl</span><span class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A \
better approach would be QTRY_VERIFY(findFileWidget());</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This will repeatedly call findFileWidget() until it \
works or until 5 seconds have passed. Then you don't need timers nor separate methods \
nor a new member variable. The rest of the test can just follow that line.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Had a problem with this since i needed to be able to close the window and i \
haven't been able to get a tryVerify that waits for qApp->activeWindow, it gets \
stuck and the dialog never shows, workarounded by waiting for the focus signal in \
qApp instead.</p></pre> <br />
<p>- Albert</p>
<br />
<p>On December 31st, 2016, 9:42 a.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Faure and Friedrich W. H. Kossebau.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2016, 9:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-integration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">7bbbd93cd3fc0abdffd3fa7f144cb50a33fafad9 makes the \
save dialog appear as Open dialog.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Simplify the code in \
that commit so it does not regress anymore.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Comes with a unit test \
(argably a bit meh since it could loop forever if the dialog does not show, but i \
guess it is good if that happens too :D)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">New test fails without the patch, works with it. Kate \
Save As dialog no longer shows as Open dialog.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/kfiledialog_unittest.cpp <span style="color: \
grey">(47a5543)</span></li>
<li>src/platformtheme/kdeplatformfiledialoghelper.cpp <span style="color: \
grey">(990b983)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129732/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7224698047034425481==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic