[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-09-29 23:50:13
Message-ID: 20160929235013.14576.98411 () mimi ! kde ! org
[Download RAW message or body]
--===============6755068772982833855==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129065/
-----------------------------------------------------------
(Updated Sept. 29, 2016, 11:50 p.m.)
Review request for KDE Frameworks and Plasma.
Repository: plasma-framework
Description
-------
QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
in earlier Qt.
This shouldn't have any behavioural effect.
Diffs
-----
src/declarativeimports/core/windowthumbnail.cpp \
0453c092f7a7144f04fdacc81b031e8c352fa23b
Diff: https://git.reviewboard.kde.org/r/129065/diff/
Testing (updated)
-------
Ran on my nvidia machine and moused over the taskbar.
I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" \
remaining constant
Thanks,
David Edmundson
--===============6755068772982833855==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129065/">https://git.reviewboard.kde.org/r/129065/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2016, 11:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">QQuickWindow::NoStage was new in Qt5.6. This uses a value that's \
valid in earlier Qt.
This shouldn't have any behavioural effect.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ran on my nvidia machine and moused over the \
taskbar.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I got thumbnails as expected, but also Nvidia-settings \
shows "user dedicated memory" remaining constant</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: \
grey">(0453c092f7a7144f04fdacc81b031e8c352fa23b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129065/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6755068772982833855==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic