[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Request, 3 lines] D2892: [Image Wallpaper] Hide background color Rectangle if it wou
From:       "broulik (Kai Uwe Broulik)" <noreply () phabricator ! kde ! org>
Date:       2016-09-30 8:30:48
Message-ID: differential-rev-PHID-DREV-nnkpj573iawcjxzl2ijx-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There's no point in rendering a colored rectangle behind a full-size wallpaper.

TEST PLAN
  Verified in GammaRay that there's no Rectangle visible behind the wallpaper if I \
set it to "Scale".  
  Even if the other image is unloaded (its source is set to empty when the animation \
finishes) its paintedWidth/height seems to stay, so the condition is pretty simple.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2892

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Attachment #3 (text/html)]

<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: \
Plasma.<br />broulik set the repository for this revision to rPLASMAWORKSPACE Plasma \
Workspace.<br />Restricted Application added a project: Plasma.<br />Restricted \
Application added a subscriber: plasma-devel. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D2892" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>There&#039;s no point in rendering a colored rectangle behind \
a full-size wallpaper.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Verified in GammaRay that there&#039;s no Rectangle visible \
behind the wallpaper if I set it to &quot;Scale&quot;.</p>

<p>Even if the other image is unloaded (its source is set to empty when the animation \
finishes) its paintedWidth/height seems to stay, so the condition is pretty \
simple.</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D2892" \
rel="noreferrer">https://phabricator.kde.org/D2892</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>wallpapers/image/imagepackage/contents/ui/main.qml</div></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]