From kde-panel-devel Thu Sep 29 23:50:13 2016 From: David Edmundson Date: Thu, 29 Sep 2016 23:50:13 +0000 To: kde-panel-devel Subject: Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6 Message-Id: <20160929235013.14576.98411 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147519303814451 --===============6755068772982833855== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ ----------------------------------------------------------- (Updated Sept. 29, 2016, 11:50 p.m.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description ------- QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid in earlier Qt. This shouldn't have any behavioural effect. Diffs ----- src/declarativeimports/core/windowthumbnail.cpp 0453c092f7a7144f04fdacc81b031e8c352fa23b Diff: https://git.reviewboard.kde.org/r/129065/diff/ Testing (updated) ------- Ran on my nvidia machine and moused over the taskbar. I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" remaining constant Thanks, David Edmundson --===============6755068772982833855== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/

Review request for KDE Frameworks and Plasma.
By David Edmundson.

Updated Sept. 29, 2016, 11:50 p.m.

Repository: plasma-framework

Description 

QQuickWindow::NoStage was new in Qt5.6. This uses a value that's valid
in earlier Qt.

This shouldn't have any behavioural effect.

Testing (updated)

Ran on my nvidia machine and moused over the taskbar.


I got thumbnails as expected, but also Nvidia-settings shows "user dedicated memory" remaining constant

Diffs

  • src/declarativeimports/core/windowthumbnail.cpp (0453c092f7a7144f04fdacc81b031e8c352fa23b)

View Diff
--===============6755068772982833855==--