From kde-panel-devel  Tue Aug 30 14:33:49 2016
From: =?utf-8?q?graesslin_=28Martin_Gr=C3=A4=C3=9Flin=29?= <noreply () phabricator ! kde ! or
Date: Tue, 30 Aug 2016 14:33:49 +0000
To: kde-panel-devel
Subject: [Differential] [Commented On] D2627: Set the restore geometry after placing a ShellClient for the fi
Message-Id: <20160830143349.16660.38409.3C8BB100 () phabricator ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=147256765318308
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--e372ebfb45da4bcd96c509eb94607034"

--e372ebfb45da4bcd96c509eb94607034
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

graesslin added a comment.


  In https://phabricator.kde.org/D2627#48943, @luebking wrote:
  
  > Fixwise good, APIwise, maybe add AbstractClient::placeIn(QRect &area) { Placement::self()->place(this, area); setGeometryRestore(geometry()); } to
  >  a) prevent uninformed messing around with the restore geomery
  >  b) guarantee sync behavior (when placing occurs)
  >
  > ?
  
  
  yep makes sense.

REPOSITORY
  rKWIN KWin

REVISION DETAIL
  https://phabricator.kde.org/D2627

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #kwin, #plasma_on_wayland, bshah
Cc: luebking, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas

--e372ebfb45da4bcd96c509eb94607034
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<table><tr><td=20style=3D"">graesslin=20added=20a=20comment.</td><a=20style=
=3D"text-decoration:=20none;=20padding:=204px=208px;=20margin:=200=208px=20=
8px;=20float:=20right;=20color:=20#464C5C;=20font-weight:=20bold;=20border-=
radius:=203px;=20background-color:=20#F7F7F9;=20background-image:=20linear-=
gradient(to=20bottom,#fff,#f1f0f1);=20display:=20inline-block;=20border:=20=
1px=20solid=20rgba(71,87,120,.2);"=20href=3D"https://phabricator.kde.org/D2=
627"=20rel=3D"noreferrer">View=20Revision</a></tr></table><br=20/><div><div=
><blockquote=20style=3D"border-left:=203px=20solid=20#8C98B8;
=20=20=20=20=20=20=20=20=20=20color:=20#6B748C;
=20=20=20=20=20=20=20=20=20=20font-style:=20italic;
=20=20=20=20=20=20=20=20=20=20margin:=204px=200=2012px=200;
=20=20=20=20=20=20=20=20=20=20padding:=208px=2012px;
=20=20=20=20=20=20=20=20=20=20background-color:=20#F8F9FC;">
<div=20style=3D"font-style:=20normal;
=20=20=20=20=20=20=20=20=20=20padding-bottom:=204px;">In=20<a=20href=3D"htt=
ps://phabricator.kde.org/D2627#48943"=20style=3D"background-color:=20#e7e7e=
7;
=20=20=20=20=20=20=20=20=20=20border-color:=20#e7e7e7;
=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20padding:=200=204px;
=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20color:=20black;text-decoration:=20none;"=20re=
l=3D"noreferrer">D2627#48943</a>,=20<a=20href=3D"https://phabricator.kde.or=
g/p/luebking/"=20style=3D"
=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20color:=20#19558d;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20background-color:=20#f1f7ff;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border:=201px=20solid=20tra=
nsparent;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20border-radius:=203px;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20font-weight:=20bold;
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20padding:=200=204px;"=20rel=
=3D"noreferrer">@luebking</a>=20wrote:</div>
<div=20style=3D"margin:=200;
=20=20=20=20=20=20=20=20=20=20padding:=200;
=20=20=20=20=20=20=20=20=20=20border:=200;
=20=20=20=20=20=20=20=20=20=20color:=20rgb(107,=20116,=20140);"><p>Fixwise=
=20good,=20APIwise,=20maybe=20add=20AbstractClient::placeIn(QRect=20&amp;ar=
ea)=20{=20Placement::self()-&gt;place(this,=20area);=20setGeometryRestore(g=
eometry());=20}=20to<br=20/>
=20a)=20prevent=20uninformed=20messing=20around=20with=20the=20restore=20ge=
omery<br=20/>
=20b)=20guarantee=20sync=20behavior=20(when=20placing=20occurs)</p>

<p>?</p></div>
</blockquote>

<p>yep=20makes=20sense.</p></div></div><br=20/><div><strong>REPOSITORY</str=
ong><div><div>rKWIN=20KWin</div></div></div><br=20/><div><strong>REVISION=
=20DETAIL</strong><div><a=20href=3D"https://phabricator.kde.org/D2627"=20re=
l=3D"noreferrer">https://phabricator.kde.org/D2627</a></div></div><br=20/><=
div><strong>EMAIL=20PREFERENCES</strong><div><a=20href=3D"https://phabricat=
or.kde.org/settings/panel/emailpreferences/"=20rel=3D"noreferrer">https://p=
habricator.kde.org/settings/panel/emailpreferences/</a></div></div><br=20/>=
<div><strong>To:=20</strong>graesslin,=20KWin,=20Plasma=20on=20Wayland,=20b=
shah<br=20/><strong>Cc:=20</strong>luebking,=20plasma-devel,=20kwin,=20lesl=
iezhai,=20ali-mohamed,=20hardening,=20jensreuterberg,=20abetts,=20sebas<br=
=20/></div>
--e372ebfb45da4bcd96c509eb94607034--