'Review Request 128332: [Plasma-nm] Indicate flight mode in system tray icon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 128332: [Plasma-nm] Indicate flight mode in system tray icon
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-06-30 20:21:20
Message-ID: 20160630202120.3798.20659 () mimi ! kde ! org
[Download RAW message or body]

--===============4612323966929853732==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128332/
-----------------------------------------------------------

Review request for Network Management, Plasma and KDE Usability.

Repository: plasma-nm

Description
-------

This changes the tray icon to the airplane icon when in flight mode.

Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a \
PlasmaCore.Svg to be consisteht with the tray icon.

BUG: 364626

Diffs
-----

  applet/contents/ui/SwitchButton.qml 3ea3079 
  applet/contents/ui/Toolbar.qml 64b6e0a 
  libs/declarative/connectionicon.h 499b4f6 
  libs/declarative/connectionicon.cpp 90060a3 

Diff: https://git.reviewboard.kde.org/r/128332/diff/

Testing
-------

Enabled flightmode, got airplane icon
Disabled flightmode, briefly got "no network" icon until my wifi was connected again.

The flight mode is only shown when flight mode is enabled and there really isn't any \
connection.

NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to \
network-flightmode-on and network-flightmode-off (keeping the old ones in there for \
compatibility!) so Plasma IconItem finds it.

File Attachments
----------------

Flightmode icon
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png

Thanks,

Kai Uwe Broulik

--===============4612323966929853732==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128332/">https://git.reviewboard.kde.org/r/128332/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Network Management, Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This changes the tray icon to the airplane icon when \
in flight mode.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Also changes the SwitchButton to use a \
PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray \
icon.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 364626</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Enabled flightmode, got airplane icon Disabled \
flightmode, briefly got "no network" icon until my wifi was connected again.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The flight mode is only shown when flight mode is enabled and there really \
isn't any connection.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">NOTE VDG: The icon flightmode-on and \
flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off \
(keeping the old ones in there for compatibility!) so Plasma IconItem finds \
it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applet/contents/ui/SwitchButton.qml <span style="color: \
grey">(3ea3079)</span></li>

 <li>applet/contents/ui/Toolbar.qml <span style="color: grey">(64b6e0a)</span></li>

 <li>libs/declarative/connectionicon.h <span style="color: \
grey">(499b4f6)</span></li>

 <li>libs/declarative/connectionicon.cpp <span style="color: \
grey">(90060a3)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128332/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png">Flightmode \
icon</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4612323966929853732==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 