--===============4540322870569764261== Content-Type: multipart/alternative; boundary="===============4612323966929853732==" --===============4612323966929853732== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128332/ ----------------------------------------------------------- Review request for Network Management, Plasma and KDE Usability. Repository: plasma-nm Description ------- This changes the tray icon to the airplane icon when in flight mode. Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon. BUG: 364626 Diffs ----- applet/contents/ui/SwitchButton.qml 3ea3079 applet/contents/ui/Toolbar.qml 64b6e0a libs/declarative/connectionicon.h 499b4f6 libs/declarative/connectionicon.cpp 90060a3 Diff: https://git.reviewboard.kde.org/r/128332/diff/ Testing ------- Enabled flightmode, got airplane icon Disabled flightmode, briefly got "no network" icon until my wifi was connected again. The flight mode is only shown when flight mode is enabled and there really isn't any connection. NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it. File Attachments ---------------- Flightmode icon https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/df8a84c2-5a91-42d1-be43-70685061c8e4__Screenshot_20160630_221424.png Thanks, Kai Uwe Broulik --===============4612323966929853732== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128332/

Review request for Network Management, Plasma and KDE Usability.

By Kai Uwe Broulik.

Repository: plasma-nm

Description

This changes the tray icon to the airplane icon when in flight mode.

Also changes the SwitchButton to use a PlasmaCore.IconItem instead of a PlasmaCore.Svg to be consisteht with the tray icon.

BUG: 364626

Testing

Enabled flightmode, got airplane icon Disabled flightmode, briefly got "no network" icon until my wifi was connected again.

The flight mode is only shown when flight mode is enabled and there really isn't any connection.

NOTE VDG: The icon flightmode-on and flightmode-off need to be renamed to network-flightmode-on and network-flightmode-off (keeping the old ones in there for compatibility!) so Plasma IconItem finds it.

Diffs

applet/contents/ui/SwitchButton.qml (3ea3079)
applet/contents/ui/Toolbar.qml (64b6e0a)
libs/declarative/connectionicon.h (499b4f6)
libs/declarative/connectionicon.cpp (90060a3)

File Attachments

Flightmode icon

--===============4612323966929853732==-- --===============4540322870569764261== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4540322870569764261==--