'Review Request 128331: [Plasma-nm] Provide better notification icons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 128331: [Plasma-nm] Provide better notification icons
From:       Kai Uwe Broulik <kde () privat ! broulik ! de>
Date:       2016-06-30 20:17:51
Message-ID: 20160630201751.3798.41631 () mimi ! kde ! org
[Download RAW message or body]

--===============3221137161162800410==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128331/
-----------------------------------------------------------

Review request for Network Management, Plasma and KDE Usability.

Repository: plasma-nm

Description
-------

This improves the most common case by showing dedicated icons for when \
connecting/disconnecting wireless and wired connections instead of showing the \
generic warning/information icon.

Also change from notification pixmap to iconName.

Diffs
-----

  kded/notification.cpp e3d19ad 

Diff: https://git.reviewboard.kde.org/r/128331/diff/

Testing
-------

Connected and disconnected my wifi

File Attachments
----------------

Connected
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/b800147b-0e0e-4cad-87c2-6045fbe6ab65__Screenshot_20160630_221435.png
 Disconnected
  https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/0cb34ebd-9d92-45d0-9c15-e439b1270287__Screenshot_20160630_221424.png

Thanks,

Kai Uwe Broulik

--===============3221137161162800410==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128331/">https://git.reviewboard.kde.org/r/128331/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Network Management, Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This improves the most common case by showing \
dedicated icons for when connecting/disconnecting wireless and wired connections \
instead of showing the generic warning/information icon.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
change from notification pixmap to iconName.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Connected and disconnected my wifi</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kded/notification.cpp <span style="color: grey">(e3d19ad)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128331/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/b800147b-0e0e-4cad-87c2-6045fbe6ab65__Screenshot_20160630_221435.png">Connected</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/30/0cb34ebd \
-9d92-45d0-9c15-e439b1270287__Screenshot_20160630_221424.png">Disconnected</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3221137161162800410==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 