[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1976: Image of the Day wallpaper plugin
From: sebas_(Sebastian_Kügler) <noreply () phabricator ! kde ! org>
Date: 2016-06-23 10:31:15
Message-ID: 20160623103111.102310.92526.621D7593 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
sebas requested changes to this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision now requires changes to proceed.
There are lots of ; (at the end of every line of QML. We generally don't do that. \
In order to make the code more consistent, please remove them. (They're fine in your \
javascript functions.)
INLINE COMMENTS
> config.qml:49
> +
> + font.pointSize: theme.defaultFont.pointSize * 1.25;
> + font.bold: true;
Use PlasmaExtras.Heading instead of sizing on your own, this will lead to more \
consistency. Look at other config dialogs how it's done.
> config.qml:120
> + width: parent.width - 2 * units.smallSpacing;
> + height: theme.mSize(theme.defaultFont).height;
> + color: bgColorDialog.color;
use units.gridUnit here.
> config.qml:178
> + if (intervalHours.value < 1) {
> + intervalMinutes.minimumValue = 15;
> + } else {
So it will at most switch every 15 minutes? Seems a bit long as minimal value to \
me...
> config.qml:205
> + id: fallbackImageButton;
> + width: theme.mSize(theme.defaultFont).width * 24;
> + text: {
units.gridUnit instead of theme.mSize
> config.qml:237
> +
> + font.pointSize: theme.defaultFont.pointSize * 1.25;
> + font.bold: true;
PlasmaExtras.Heading
REPOSITORY
rKDEPLASMAADDONS Plasma Addons
REVISION DETAIL
https://phabricator.kde.org/D1976
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bgupta, #plasma, sebas
Cc: sebas, graesslin, davidedmundson, plasma-devel, #plasma, jensreuterberg
[Attachment #5 (text/html)]
<table><tr><td style="">sebas requested changes to this revision.<br />sebas added a \
reviewer: sebas.<br />sebas added a comment.<br />This revision now requires changes \
to proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1976" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>There are lots of ; (at the end of every \
line of QML. We generally don't do that. In order to make the code more \
consistent, please remove them. (They're fine in your javascript \
functions.)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7560" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">config.qml:49</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">font.pointSize:</span> \
<span style="color: #004012">theme</span><span class="p">.</span><span style="color: \
#004012">defaultFont</span><span class="p">.</span><span style="color: \
#004012">pointSize</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">1.25</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">font.bold:</span> <span style="color: #000a65">true</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use \
PlasmaExtras.Heading instead of sizing on your own, this will lead to more \
consistency. Look at other config dialogs how it's done.</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1976#inline-7561" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">config.qml:120</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">width:</span> \
<span style="color: #004012">parent</span><span class="p">.</span><span style="color: \
#004012">width</span> <span style="color: #aa2211">-</span> <span style="color: \
#601200">2</span> <span style="color: #aa2211">*</span> <span style="color: \
#004012">units</span><span class="p">.</span><span style="color: \
#004012">smallSpacing</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">height:</span> <span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">mSize</span><span \
class="p">(</span><span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">defaultFont</span><span \
class="p">).</span><span style="color: #004012">height</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span style="color: #aa4000">color:</span> <span style="color: \
#004012">bgColorDialog</span><span class="p">.</span><span style="color: \
#004012">color</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use \
units.gridUnit here.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7562" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">config.qml:178</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span style="color: #004012">intervalHours</span><span \
class="p">.</span><span style="color: #004012">value</span> <span style="color: \
#aa2211"><</span> <span style="color: #601200">1</span><span class="p">)</span> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span style="color: \
#004012">intervalMinutes</span><span class="p">.</span><span style="color: \
#004012">minimumValue</span> <span style="color: #aa2211">=</span> <span \
style="color: #601200">15</span><span class="p">;</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span> \
<span style="color: #aa4000">else</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So \
it will at most switch every 15 minutes? Seems a bit long as minimal value to \
me...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1976#inline-7563" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">config.qml:205</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">id: \
fallbackImageButton</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">width:</span> <span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">mSize</span><span \
class="p">(</span><span style="color: #004012">theme</span><span \
class="p">.</span><span style="color: #004012">defaultFont</span><span \
class="p">).</span><span style="color: #004012">width</span> <span style="color: \
#aa2211">*</span> <span style="color: #601200">24</span><span class="p">;</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> \
<span style="color: #aa4000">text:</span> <span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">units.gridUnit instead of theme.mSize</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1976#inline-7564" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">config.qml:237</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;"> <span style="color: #aa4000">font.pointSize:</span> \
<span style="color: #004012">theme</span><span class="p">.</span><span style="color: \
#004012">defaultFont</span><span class="p">.</span><span style="color: \
#004012">pointSize</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">1.25</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span style="color: \
#aa4000">font.bold:</span> <span style="color: #000a65">true</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">PlasmaExtras.Heading</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKDEPLASMAADDONS Plasma \
Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1976" \
rel="noreferrer">https://phabricator.kde.org/D1976</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>bgupta, Plasma, sebas<br /><strong>Cc: </strong>sebas, \
graesslin, davidedmundson, plasma-devel, Plasma, jensreuterberg<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic