[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: [Differential] [Requested Changes To] D1982: Validate activities in setOnActivities
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-06-24 6:48:30
Message-ID: 20160624064830.367.43015.9B327424 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision now requires changes to proceed.
I'd love to see an autotest for this. If you have any questions on how to get this \
autotested I'm happy to help, but I guess you find the way there yourself - take any \
of the tests in autotest/wayland which interact with X11 clients as an example.
INLINE COMMENTS
> client.cpp:1251-1252
> +
> + foreach(const QString &activity, newActivitiesList) {
> + if(!allActivities.contains(activity)) {
> + newActivitiesList.removeOne(activity);
coding style
> client.cpp:1251-1254
> + foreach(const QString &activity, newActivitiesList) {
> + if(!allActivities.contains(activity)) {
> + newActivitiesList.removeOne(activity);
> + }
this looks dangerous: your removing from the container you are iterating over. I have \
seen this crash to often. I'd suggest to use the iterator API and use erase on the \
container.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D1982
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, graesslin
Cc: graesslin, kwin, hardening, jensreuterberg, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added a reviewer: graesslin.<br />graesslin added a comment.<br />This revision now \
requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1982" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><p>I'd love to see an autotest for \
this. If you have any questions on how to get this autotested I'm happy to help, \
but I guess you find the way there yourself - take any of the tests in \
autotest/wayland which interact with X11 clients as an example.</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1982#inline-7584" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">client.cpp:1251-1252</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="n">foreach</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span style="color: #aa2211">&</span><span \
class="n">activity</span><span class="p">,</span> <span \
class="n">newActivitiesList</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
style="color: #aa4000">if</span><span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">allActivities</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span class="n">activity</span><span \
class="p">))</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span \
class="n">newActivitiesList</span><span class="p">.</span><span \
class="n">removeOne</span><span class="p">(</span><span \
class="n">activity</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">coding style</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D1982#inline-7585" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">client.cpp:1251-1254</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="n">foreach</span><span \
class="p">(</span><span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span style="color: #aa2211">&</span><span \
class="n">activity</span><span class="p">,</span> <span \
class="n">newActivitiesList</span><span class="p">)</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"> <span \
style="color: #aa4000">if</span><span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">allActivities</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span class="n">activity</span><span \
class="p">))</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span \
class="n">newActivitiesList</span><span class="p">.</span><span \
class="n">removeOne</span><span class="p">(</span><span \
class="n">activity</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: #d0ffd0;"> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">this looks dangerous: your removing from the container you are \
iterating over. I have seen this crash to often. I'd suggest to use the iterator \
API and use erase on the container.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWIN KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1982" \
rel="noreferrer">https://phabricator.kde.org/D1982</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>davidedmundson, Plasma, graesslin<br /><strong>Cc: \
</strong>graesslin, kwin, hardening, jensreuterberg, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic