[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: [Differential] [Requested Changes To] D1925: Improve window-on-screen intersection test.
From: graesslin_(Martin_Gräßlin) <noreply () phabricator ! kde ! or
Date: 2016-06-17 6:02:16
Message-ID: 20160617060216.22167.30792.67D32356 () phabricator ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
graesslin requested changes to this revision.
graesslin added a reviewer: graesslin.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> xwindowtasksmodel.cpp:785
> for (int i = 0; i < screens.count(); ++i) {
> - if (screens.at(i)->geometry().intersects(info->geometry())) {
> + if (screens.at(i)->geometry().contains(info->frameGeometry().center())) {
> return i;
What if the center of the window is not on any screen? Yes that's possible.
KWin's implementation calculates the distance to every screen and uses the minimal \
distance as the screen it's on. Relevant methods to look at: Toplevel::checkScreen \
(in toplevel.cpp) and Screens::number in screens.cpp
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1925
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, luebking, lbeltrame, #plasma, graesslin
Cc: graesslin, plasma-devel, jensreuterberg, sebas
[Attachment #5 (text/html)]
<table><tr><td style="">graesslin requested changes to this revision.<br />graesslin \
added a reviewer: graesslin.<br />graesslin added inline comments.<br />This revision \
now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px \
8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D1925" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D1925#inline-7363" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">xwindowtasksmodel.cpp:785</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #aa4000">for</span> <span \
class="p">(</span><span style="color: #aa4000">int</span> <span class="n">i</span> \
<span style="color: #aa2211">=</span> <span style="color: #601200">0</span><span \
class="p">;</span> <span class="n">i</span> <span style="color: #aa2211"><</span> \
<span class="n">screens</span><span class="p">.</span><span \
class="n">count</span><span class="p">();</span> <span style="color: \
#aa2211">++</span><span class="n">i</span><span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#ffd0d0;"> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">screens</span><span class="p">.</span><span \
class="n">at</span><span class="p">(</span><span class="n">i</span><span \
class="p">)</span><span style="color: #aa2211">-></span><span \
class="n">geometry</span><span class="p">().<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">intersect</span>s</span><span class="p">(</span><span \
class="n">info</span><span style="color: #aa2211">-><span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">g</span>eometry</span><span class="p">()))</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;"> <span style="color: #aa4000">if</span> <span \
class="p">(</span><span class="n">screens</span><span class="p">.</span><span \
class="n">at</span><span class="p">(</span><span class="n">i</span><span \
class="p">)</span><span style="color: #aa2211">-></span><span \
class="n">geometry</span><span class="p">().<span class="bright"></span></span><span \
class="bright"></span><span class="n"><span \
class="bright">contain</span>s</span><span class="p">(</span><span \
class="n">info</span><span style="color: #aa2211">-><span \
class="bright"></span></span><span class="bright"></span><span class="n"><span \
class="bright">frameG</span>eometry<span class="bright"></span></span><span \
class="bright"></span><span class="p"><span class="bright">().</span></span><span \
class="bright"></span><span class="n"><span class="bright">center</span></span><span \
class="p">()))</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #aa4000">return</span> <span \
class="n">i</span><span class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What \
if the center of the window is not on any screen? Yes that's possible.</p>
<p style="padding: 0; margin: 8px;">KWin's implementation calculates the \
distance to every screen and uses the minimal distance as the screen it's on. \
Relevant methods to look at: Toplevel::checkScreen (in toplevel.cpp) and \
Screens::number in screens.cpp</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma \
Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1925" \
rel="noreferrer">https://phabricator.kde.org/D1925</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>hein, luebking, lbeltrame, Plasma, graesslin<br \
/><strong>Cc: </strong>graesslin, plasma-devel, jensreuterberg, sebas<br /></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic