[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D1726: Introduce a test server
From:       "bshah (Bhushan Shah)" <noreply () phabricator ! kde ! org>
Date:       2016-05-31 14:12:02
Message-ID: 20160531141201.10674.7927.4FC11D1B () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


bshah added inline comments.

INLINE COMMENTS

> main.cpp:30-33
> +    const auto arguments = parser.positionalArguments();
> +    if (arguments.size() != 1) {
> +        return 1;
> +    }

It might be possible that one want to use executable with command line option... lets \
not restrict it to 1? and have >= 1?

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: bshah, plasma-devel, sebas


[Attachment #5 (text/html)]

<div>bshah added inline comments.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1726#inline-6680" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">main.cpp:30-33</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">    <span style="color: #aa4000">const</span> <span \
style="color: #aa4000">auto</span> <span class="n">arguments</span> <span \
style="color: #aa2211">=</span> <span class="n">parser</span><span \
class="p">.</span><span class="n">positionalArguments</span><span \
class="p">();</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span \
class="n">arguments</span><span class="p">.</span><span class="n">size</span><span \
class="p">()</span> <span style="color: #aa2211">!=</span> <span style="color: \
#601200">1</span><span class="p">)</span> <span class="p">{</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span \
style="color: #aa4000">return</span> <span style="color: #601200">1</span><span \
class="p">;</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
#d0ffd0;">    <span class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It \
might be possible that one want to use executable with command line option... lets \
not restrict it to 1? and have &gt;= 1?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWAYLAND KWayland</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D1726" \
rel="noreferrer">https://phabricator.kde.org/D1726</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, Plasma<br /><strong>Cc: </strong>bshah, \
plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]