--===============7302785883681120435==
Content-Type: multipart/alternative; boundary="b09d64c7d47b466ba987bb92e281c24a"

--b09d64c7d47b466ba987bb92e281c24a
Content-Type: text/plain; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

bshah added inline comments.

INLINE COMMENTS

> main.cpp:30-33
> +    const auto arguments = parser.positionalArguments();
> +    if (arguments.size() != 1) {
> +        return 1;
> +    }

It might be possible that one want to use executable with command line option... lets not restrict it to 1? and have >= 1?

REPOSITORY
  rKWAYLAND KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1726

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: bshah, plasma-devel, sebas

--b09d64c7d47b466ba987bb92e281c24a
Content-Type: text/html; charset="ascii"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable

<div>bshah=20added=20inline=20comments.</div><br=20/><div><strong>INLINE=20=
COMMENTS</strong><div><div=20style=3D"margin:=206px=200=2012px=200;"><div=
=20style=3D"border:=201px=20solid=20#C7CCD9;=20border-radius:=203px;"><div=
=20style=3D"padding:=200;=20background:=20#F7F7F7;=20border-color:=20#e3e4e=
8;=20border-style:=20solid;=20border-width:=200=200=201px=200;=20margin:=20=
0;"><div=20style=3D"color:=20#74777d;=20background:=20#eff2f4;=20padding:=
=206px=208px;=20overflow:=20hidden;"><a=20style=3D"float:=20right;=20text-d=
ecoration:=20none;"=20href=3D"https://phabricator.kde.org/D1726#inline-6680=
"=20rel=3D"noreferrer">View=20Inline</a><span=20style=3D"color:=20#4b4d51;=
=20font-weight:=20bold;">main.cpp:30-33</span></div>
<div=20style=3D"font:=2011px/15px=20&quot;Menlo&quot;,=20&quot;Consolas&quo=
t;,=20&quot;Monaco&quot;,=20monospace;=20white-space:=20pre-wrap;=20clear:=
=20both;=20padding:=204px=200;=20margin:=200;"><div=20style=3D"padding:=200=
=208px;=20margin:=200=204px;=20background:=20#d0ffd0;">=20=20=20=20<span=20=
style=3D"color:=20#aa4000">const</span>=20<span=20style=3D"color:=20#aa4000=
">auto</span>=20<span=20class=3D"n">arguments</span>=20<span=20style=3D"col=
or:=20#aa2211">=3D</span>=20<span=20class=3D"n">parser</span><span=20class=
=3D"p">.</span><span=20class=3D"n">positionalArguments</span><span=20class=
=3D"p">();</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20style=3D"color:=20#aa4000">if</span>=20<s=
pan=20class=3D"p">(</span><span=20class=3D"n">arguments</span><span=20class=
=3D"p">.</span><span=20class=3D"n">size</span><span=20class=3D"p">()</span>=
=20<span=20style=3D"color:=20#aa2211">!=3D</span>=20<span=20style=3D"color:=
=20#601200">1</span><span=20class=3D"p">)</span>=20<span=20class=3D"p">{</s=
pan>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20=20=20=20=20<span=20style=3D"color:=20#aa4000">re=
turn</span>=20<span=20style=3D"color:=20#601200">1</span><span=20class=3D"p=
">;</span>
</div><div=20style=3D"padding:=200=208px;=20margin:=200=204px;=20background=
:=20#d0ffd0;">=20=20=20=20<span=20class=3D"p">}</span>
</div></div></div>
<div=20style=3D"margin:=208px=200;=20padding:=200=2012px;"><p=20style=3D"pa=
dding:=200;=20margin:=208px;">It=20might=20be=20possible=20that=20one=20wan=
t=20to=20use=20executable=20with=20command=20line=20option...=20lets=20not=
=20restrict=20it=20to=201?=20and=20have=20&gt;=3D=201?</p></div></div></div=
></div></div><br=20/><div><strong>REPOSITORY</strong><div><div>rKWAYLAND=20=
KWayland</div></div></div><br=20/><div><strong>REVISION=20DETAIL</strong><d=
iv><a=20href=3D"https://phabricator.kde.org/D1726"=20rel=3D"noreferrer">htt=
ps://phabricator.kde.org/D1726</a></div></div><br=20/><div><strong>EMAIL=20=
PREFERENCES</strong><div><a=20href=3D"https://phabricator.kde.org/settings/=
panel/emailpreferences/"=20rel=3D"noreferrer">https://phabricator.kde.org/s=
ettings/panel/emailpreferences/</a></div></div><br=20/><div><strong>To:=20<=
/strong>graesslin,=20Plasma<br=20/><strong>Cc:=20</strong>bshah,=20plasma-d=
evel,=20sebas<br=20/></div>
--b09d64c7d47b466ba987bb92e281c24a--

--===============7302785883681120435==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl
dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo=

--===============7302785883681120435==--