[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    [Differential] [Changed Subscribers] D1727: Add a test case for KIdleTime
From:       "bshah (Bhushan Shah)" <noreply () phabricator ! kde ! org>
Date:       2016-06-01 6:25:26
Message-ID: 20160601062526.7415.41413.EE9E2100 () phabricator ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


bshah added inline comments.

INLINE COMMENTS

> idle_test.cpp:79
> +    QCOMPARE(spy.count(), 0);
> +    m_fakeInput->requestPointerMove(QSizeF(1, 2));
> +    QVERIFY(spy.wait());

In the past we've seen that touch events didn't resume from idle or something... \
perhaps add testcase for that?

REPOSITORY
  rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1727

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, Plasma
Cc: bshah, plasma-devel, sebas


[Attachment #5 (text/html)]

<div>bshah added inline comments.</div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D1727#inline-6784" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">idle_test.cpp:79</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: #d0ffd0;">    <span class="n">QCOMPARE</span><span \
class="p">(</span><span class="n">spy</span><span class="p">.</span><span \
class="n">count</span><span class="p">(),</span> <span style="color: \
#601200">0</span><span class="p">);</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;">    <span class="n">m_fakeInput</span><span \
style="color: #aa2211">-&gt;</span><span class="n">requestPointerMove</span><span \
class="p">(</span><span class="n">QSizeF</span><span class="p">(</span><span \
style="color: #601200">1</span><span class="p">,</span> <span style="color: \
#601200">2</span><span class="p">));</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: #d0ffd0;">    <span class="n">QVERIFY</span><span \
class="p">(</span><span class="n">spy</span><span class="p">.</span><span \
class="n">wait</span><span class="p">());</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">In \
the past we&#039;ve seen that touch events didn&#039;t resume from idle or \
something... perhaps add testcase for that?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>rKWAYLANDINTEGRATION Frameworks \
integration plugin using KWayland</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a href="https://phabricator.kde.org/D1727" \
rel="noreferrer">https://phabricator.kde.org/D1727</a></div></div><br \
/><div><strong>EMAIL PREFERENCES</strong><div><a \
href="https://phabricator.kde.org/settings/panel/emailpreferences/" \
rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br \
/><div><strong>To: </strong>graesslin, Plasma<br /><strong>Cc: </strong>bshah, \
plasma-devel, sebas<br /></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic