'Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-04-30 13:46:25
Message-ID: 20160430134625.11646.11260 () mimi ! kde ! org
[Download RAW message or body]

--===============1109846662421392584==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127794/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.

Bugs: 361928
    http://bugs.kde.org/show_bug.cgi?id=361928

Repository: kdeplasma-addons

Description
-------

Looks like a bug?
Plasmoid.icon: {
        iconSource: "face-laughing"
    }
Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits \
content again :)

Diffs
-----

  applets/comic/package/contents/ui/main.qml 2834f7f 

Diff: https://git.reviewboard.kde.org/r/127794/diff/

Testing
-------

+ Remove highlightMask, it's look outdated and unusable (selected tab is underlined)
+ Don't show image content when add provider(s) and then removes all.

Thanks,

Anthony Fieroni

--===============1109846662421392584==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127794/">https://git.reviewboard.kde.org/r/127794/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Anthony Fieroni.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=361928">361928</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Looks like a bug?
Plasmoid.icon: {
        iconSource: "face-laughing"
    }
Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits \
content again :)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Remove highlightMask, \
it's look outdated and unusable (selected tab is underlined)</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Don't \
show image content when add provider(s) and then removes all.</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/comic/package/contents/ui/main.qml <span style="color: \
grey">(2834f7f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127794/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1109846662421392584==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 