[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 127794: [Comic] Plasmoid icon is placed in plasmoid content
From: Marco Martin <notmart () gmail ! com>
Date: 2016-05-04 15:46:20
Message-ID: 20160504154620.15439.11158 () mimi ! kde ! org
[Download RAW message or body]
--===============3590034324010854227==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127794/#review95171
-----------------------------------------------------------
Fix it, then Ship it!
it's ok, except line 45
applets/comic/package/contents/ui/main.qml (line 45)
<https://git.reviewboard.kde.org/r/127794/#comment64585>
no, plasmoid.icon is just an icon name, this wouldn't work
- Marco Martin
On April 30, 2016, 1:46 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127794/
> -----------------------------------------------------------
>
> (Updated April 30, 2016, 1:46 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Bugs: 361928
> http://bugs.kde.org/show_bug.cgi?id=361928
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> Looks like a bug?
> Plasmoid.icon: {
> iconSource: "face-laughing"
> }
> Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits \
> content again :)
>
> Diffs
> -----
>
> applets/comic/package/contents/ui/main.qml 2834f7f
>
> Diff: https://git.reviewboard.kde.org/r/127794/diff/
>
>
> Testing
> -------
>
> + Remove highlightMask, it's look outdated and unusable (selected tab is \
> underlined) + Don't show image content when add provider(s) and then removes all.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============3590034324010854227==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127794/">https://git.reviewboard.kde.org/r/127794/</a>
</td>
</tr>
</table>
<br />
<p>
Fix it, then Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's \
ok, except line 45</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127794/diff/1/?file=461942#file461942line45" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/comic/package/contents/ui/main.qml</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">45</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">Plasmoid.icon:</span> <span class="s2"><span \
class="hl">"face-laughing"</span></span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">45</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">Plasmoid.icon:</span> <span class="p"><span \
class="hl">{</span></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">no, \
plasmoid.icon is just an icon name, this wouldn't work</p></pre> </div>
</div>
<br />
<p>- Marco Martin</p>
<br />
<p>On April 30th, 2016, 1:46 p.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated April 30, 2016, 1:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=361928">361928</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks like a bug?
Plasmoid.icon: {
iconSource: "face-laughing"
}
Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits \
content again :)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Remove highlightMask, \
it's look outdated and unusable (selected tab is underlined)</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Don't \
show image content when add provider(s) and then removes all.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/comic/package/contents/ui/main.qml <span style="color: \
grey">(2834f7f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127794/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3590034324010854227==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic