--===============4443700294501416549== Content-Type: multipart/alternative; boundary="===============1109846662421392584==" --===============1109846662421392584== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/ ----------------------------------------------------------- Review request for Plasma and Marco Martin. Bugs: 361928 http://bugs.kde.org/show_bug.cgi?id=361928 Repository: kdeplasma-addons Description ------- Looks like a bug? Plasmoid.icon: { iconSource: "face-laughing" } Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits content again :) Diffs ----- applets/comic/package/contents/ui/main.qml 2834f7f Diff: https://git.reviewboard.kde.org/r/127794/diff/ Testing ------- + Remove highlightMask, it's look outdated and unusable (selected tab is underlined) + Don't show image content when add provider(s) and then removes all. Thanks, Anthony Fieroni --===============1109846662421392584== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127794/

Review request for Plasma and Marco Martin.
By Anthony Fieroni.
Bugs: 361928
Repository: kdeplasma-addons

Description 

Looks like a bug?
Plasmoid.icon: {
        iconSource: "face-laughing"
    }
Partial fix, if you resize plasmoid without load comic provider, plasmoid.icon fits content again :)

Testing 

    

  • Remove highlightMask, it's look outdated and unusable (selected tab is underlined)
    • 

  • Don't show image content when add provider(s) and then removes all.
    •

Diffs

  • applets/comic/package/contents/ui/main.qml (2834f7f)

View Diff
--===============1109846662421392584==-- --===============4443700294501416549== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4443700294501416549==--