'Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package
From:       David Rosca <nowrep () gmail ! com>
Date:       2016-04-29 9:56:15
Message-ID: 20160429095615.8442.96770 () mimi ! kde ! org
[Download RAW message or body]

--===============8659806004917898401==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On April 29, 2016, 9:51 a.m., Marco Martin wrote:
> > any news on this?

Sorry, not much time now. 
But I did take a look and the test will need AppletInterface to actually test this \
case, so I think it won't be easy from plasma-framework. With the plasmashell testing \
subsystem added recently, it would be easier.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127702/#review95007
-----------------------------------------------------------

On April 21, 2016, 10:11 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127702/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 10:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source \
> property will be empty for KCM pages. This fixes correctly returning empty source \
> for KCM pages. Also return the same value from get(). 
> 
> Diffs
> -----
> 
> src/plasmaquick/configmodel.cpp 3f69073 
> 
> Diff: https://git.reviewboard.kde.org/r/127702/diff/
> 
> 
> Testing
> -------
> 
> Added qml config page to plasma-pa, KCM page now works fine.
> 
> 
> Thanks,
> 
> David Rosca
> 
> 

--===============8659806004917898401==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127702/">https://git.reviewboard.kde.org/r/127702/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On April 29th, 2016, 9:51 a.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">any news on this?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Sorry, not much time now.  But I did take a look and the test will need \
AppletInterface to actually test this case, so I think it won't be easy from \
plasma-framework. With the plasmashell testing subsystem added recently, it would be \
easier.</p></pre> <br />

<p>- David</p>

<br />
<p>On April 21st, 2016, 10:11 a.m. UTC, David Rosca wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By David Rosca.</div>

<p style="color: grey;"><i>Updated April 21, 2016, 10:11 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ConfigModel may contain ConfigCategory for both QML \
pages and KCM pages. The source property will be empty for KCM pages. This fixes \
correctly returning empty source for KCM pages. Also return the same value from \
get().</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Added qml config page to plasma-pa, KCM page now works \
fine.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/plasmaquick/configmodel.cpp <span style="color: grey">(3f69073)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127702/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8659806004917898401==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 