'Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 127755: [IconItem] Clearing pixmap makes toolbuttons invisible in some conditions
From:       Anthony Fieroni <bvbfan () abv ! bg>
Date:       2016-04-29 10:51:06
Message-ID: 20160429105106.8442.94902 () mimi ! kde ! org
[Download RAW message or body]

--===============4055651962127942901==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On Април 29, 2016, 12:49 след обяд, Marco Martin wrote:
> > you removed the way it had to disable animations when it passed from visible to \
> > invisible. this will probably bring back the weird animation of icons when the \
> > tooltips come up

I can't notice any icon animation whe tooltip cames up. Maybe this was be in the \
past?

- Anthony

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127755/#review95006
-----------------------------------------------------------

On Април 28, 2016, 9:59 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127755/
> -----------------------------------------------------------
> 
> (Updated Април 28, 2016, 9:59 преди обяд)
> 
> 
> Review request for Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> So toolbutton works, what is broken now? :)
> 
> 
> Diffs
> -----
> 
> autotests/iconitemtest.cpp db63e49 
> src/declarativeimports/core/iconitem.h 38a9c7a 
> src/declarativeimports/core/iconitem.cpp 12008f8 
> 
> Diff: https://git.reviewboard.kde.org/r/127755/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
> 

--===============4055651962127942901==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127755/">https://git.reviewboard.kde.org/r/127755/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Април 29th, 2016, 12:49 след обяд \
EEST, <b>Marco Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">you removed the way it \
had to disable animations when it passed from visible to invisible. this will \
probably bring back the weird animation of icons when the tooltips come up</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
can't notice any icon animation whe tooltip cames up. Maybe this was be in the \
past?</p></pre> <br />

<p>- Anthony</p>

<br />
<p>On Април 28th, 2016, 9:59 преди обяд EEST, Anthony Fieroni \
wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Kai Uwe Broulik, David Rosca, and Marco Martin.</div>
<div>By Anthony Fieroni.</div>

<p style="color: grey;"><i>Updated Април 28, 2016, 9:59 преди \
обяд</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So toolbutton works, what is broken now? :)</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>autotests/iconitemtest.cpp <span style="color: grey">(db63e49)</span></li>

 <li>src/declarativeimports/core/iconitem.h <span style="color: \
grey">(38a9c7a)</span></li>

 <li>src/declarativeimports/core/iconitem.cpp <span style="color: \
grey">(12008f8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127755/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4055651962127942901==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 