--===============4395077618525842014== Content-Type: multipart/alternative; boundary="===============8659806004917898401==" --===============8659806004917898401== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 29, 2016, 9:51 a.m., Marco Martin wrote: > > any news on this? Sorry, not much time now. But I did take a look and the test will need AppletInterface to actually test this case, so I think it won't be easy from plasma-framework. With the plasmashell testing subsystem added recently, it would be easier. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95007 ----------------------------------------------------------- On April 21, 2016, 10:11 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127702/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 10:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source property will be empty for KCM pages. > This fixes correctly returning empty source for KCM pages. Also return the same value from get(). > > > Diffs > ----- > > src/plasmaquick/configmodel.cpp 3f69073 > > Diff: https://git.reviewboard.kde.org/r/127702/diff/ > > > Testing > ------- > > Added qml config page to plasma-pa, KCM page now works fine. > > > Thanks, > > David Rosca > > --===============8659806004917898401== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/

On April 29th, 2016, 9:51 a.m. UTC, Marco Martin wrote:
any news on this?

Sorry, not much time now. But I did take a look and the test will need AppletInterface to actually test this case, so I think it won't be easy from plasma-framework. With the plasmashell testing subsystem added recently, it would be easier.

- David

On April 21st, 2016, 10:11 a.m. UTC, David Rosca wrote:

Review request for Plasma.

By David Rosca.

Updated April 21, 2016, 10:11 a.m.

Repository: plasma-framework

Description

ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source property will be empty for KCM pages.
This fixes correctly returning empty source for KCM pages. Also return the same value from get().

Testing

Added qml config page to plasma-pa, KCM page now works fine.

Diffs

src/plasmaquick/configmodel.cpp (3f69073)

View Diff

--===============8659806004917898401==-- --===============4395077618525842014== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4395077618525842014==--