From kde-panel-devel Thu Mar 31 20:23:43 2016 From: =?utf-8?q?Sebastian_K=C3=BCgler?= Date: Thu, 31 Mar 2016 20:23:43 +0000 To: kde-panel-devel Subject: Re: Review Request 127487: Fix bindings in KCM MuteButton Message-Id: <20160331202343.12706.38557 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=145945583800978 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8091423313432556348==" --===============8091423313432556348== Content-Type: multipart/alternative; boundary="===============6154740265251523667==" --===============6154740265251523667== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127487/#review94161 ----------------------------------------------------------- Ship it! Ship It! - Sebastian Kügler On March 24, 2016, 8:37 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127487/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 8:37 p.m.) > > > Review request for Plasma. > > > Repository: plasma-pa > > > Description > ------- > > Assigning value to muted property clears the binding. > > > Diffs > ----- > > src/kcm/package/contents/ui/DeviceListItem.qml 979c693 > src/kcm/package/contents/ui/MuteButton.qml 693ab2d > src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e > > Diff: https://git.reviewboard.kde.org/r/127487/diff/ > > > Testing > ------- > > Click mute -> unmute the device from other app -> mute button have correct state > > > Thanks, > > David Rosca > > --===============6154740265251523667== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127487/

Ship it! 

Ship It!

- Sebastian Kügler


On March 24th, 2016, 8:37 p.m. UTC, David Rosca wrote:

Review request for Plasma.
By David Rosca.

Updated March 24, 2016, 8:37 p.m.

Repository: plasma-pa

Description 

Assigning value to muted property clears the binding.

Testing 

Click mute -> unmute the device from other app -> mute button have correct state

Diffs

  • src/kcm/package/contents/ui/DeviceListItem.qml (979c693)
  • src/kcm/package/contents/ui/MuteButton.qml (693ab2d)
  • src/kcm/package/contents/ui/StreamListItem.qml (7f1d69e)

View Diff
--===============6154740265251523667==-- --===============8091423313432556348== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============8091423313432556348==--